Open
Conversation
| */ | ||
| @Override | ||
| protected Iterable getFakeInput() { | ||
| return ComputerSetProcessorUtils.getIterable(); |
Member
There was a problem hiding this comment.
this problem can be resolved as soon as we have introduced the new or better matching which support proxy objects.
Author
|
Should I rewrite the history again? |
Member
|
I think thats fine. Let's wait with merging until after the hackathon, such that we potentially get rid of the |
11fe299 to
10ab745
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds so called ComputerSets (<==> FeatureSet). A ComputerSet holds different ComputerOps which build a common known measurement-group.
Now all FirstOrderStats ops could be combined in a FirstOrderStatsComputerSet. Same goes for different groups like Zernike, Histogram or Geometric2D (and many others which have to be implemented).
There are non-configurable and configurable ComputerSets. Configurable means that each op of this ComputerSet could either be active or inactive.
The ComputerSets are processed by the ComputerSetProcessor. There are three different implementations. One for ComputerSets based on Iterables (FirstOrderStats), one for ComputerSets based on LabelRegions (Geometric2D) and one for ComputerSets which should be computed over ROIs (FirstOrderStats on every segment of a LabelRegions).
To a ComputerSetProcessor arbitrarily many ComputerSets could be added. The ComputerSetProcessor will create a Table with a column for each computed op of every ComputerSet. The IterableComputerSetProcessor creates a table with one output row and the LabelRegions- and ROIComputerSetProcessor creates a output row for each segment of the Labeling.
The ComputerSetProcessor takes care of unique column names in the output-table.
@dietzc and @ctrueden please take a look.