Skip to content

Use eval in lexical scope to fix tests #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
manphiz wants to merge 1 commit into from
Closed

Use eval in lexical scope to fix tests #214

manphiz wants to merge 1 commit into from

Conversation

@manphiz
Copy link

@manphiz manphiz commented Apr 16, 2024

  • Buttercup since 1.34 starts to support oclosure, so eval will be used in dynamic scope by default.
  • This patch ensures that eval is using lexical scope to retain previous behavior and fix tests in buttercup >=1.34.

@manphiz
Use eval in lexical scope to fix tests
6aeffc0 
* Buttercup since 1.34 starts to support oclosure, so eval will be
used in dynamic scope by default.
* This patch ensures that eval is using lexical scope to retain
previous behavior and fix tests in buttercup >=1.34.
@manphiz
Copy link
Author

manphiz commented Apr 21, 2024

Closing this in favor of #215

@manphiz manphiz closed this Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@manphiz