fix(mobile): hide video thumbnail when video is ready #19328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
shenlong-tanwen
approved these changes
Jun 25, 2025
zackpollard
approved these changes
Jul 24, 2025
…llback This avoids hiding the image before the video is ready to play
zackpollard
force-pushed
the
fix/hide-video-thumbnail-when-video-is-ready
branch
from
94f5810 to
4a7b0ea
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18701
Description
This PR changes
NativeVideoViewerPageto check if the video is ready to play and hides the video thumbnail to avoid misalignment (1 pixel wide static line on the bottom and right side of the frame.)Fixes #18701