Add ShowTemperatureUnit setting to hide F/C from weather display#553
Add ShowTemperatureUnit setting to hide F/C from weather display#553nopoz wants to merge 2 commits intoimmichFrame:mainfrom
Conversation
📝 WalkthroughWalkthroughThis change introduces a new configuration setting to control whether temperature units are displayed. The feature is implemented across the server configuration interface, model layers, data mappings, test resources, and the client-side UI component with conditional rendering logic. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🔇 Additional comments (2)
✏️ Tip: You can disable this entire section by setting Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I'm good with this too. |
Sorry, I lack behind with review. Will probably find time this weekend. |
3rob3
left a comment
There was a problem hiding this comment.
Can you update the Settings.example.json, Settings.example.yml, and example.env with this new setting please?
| public string Style => _delegate.Style; | ||
| public string? BaseFontSize => _delegate.BaseFontSize; | ||
| public bool ShowWeatherDescription => _delegate.ShowWeatherDescription; | ||
| public bool ShowTemperatureUnit => true; |
There was a problem hiding this comment.
why is this default true in the v1 settings?
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.