Conversation
…ent caching (same as images)
📝 WalkthroughWalkthroughGetVideoAsset adds optional disk-backed caching with renewal checks and a streaming fallback; it writes via a temp-to-rename flow when caching, uses a DeleteOnClose temp stream when not, defaults missing Content-Type to Changes
Sequence Diagram(s)sequenceDiagram
participant Caller
participant Logic as PooledImmichFrameLogic
participant API as Immich API
participant Disk as Filesystem
Caller->>Logic: GetVideoAsset(id)
Logic->>Logic: inspect config.DownloadImages
alt DownloadImages = true
Logic->>Disk: ensure cache dir exists
Logic->>Disk: check `id.mp4` age (RenewImagesDuration)
alt cached & fresh
Disk-->>Logic: open cached file stream
Logic-->>Caller: return disk-backed stream + Content-Type
else missing or expired
Logic->>API: PlayAssetVideoAsync(id)
API-->>Logic: response (body, Content-Type)
Logic->>Disk: write to temp file -> rename to `id.mp4`
Disk-->>Logic: open cached file stream
Logic-->>Caller: return disk-backed stream + Content-Type
end
else DownloadImages = false
Logic->>API: PlayAssetVideoAsync(id)
API-->>Logic: response (body, Content-Type)
Logic->>Logic: default Content-Type to "video/mp4" if absent
Logic->>Disk: create temp file (DeleteOnClose), write bytes
Disk-->>Logic: open temp-file stream
Logic-->>Caller: return temp-file-backed stream + Content-Type
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 🧹 Recent nitpick comments
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@ImmichFrame.Core/Logic/PooledImmichFrameLogic.cs`:
- Around line 165-206: In GetVideoAsset (PooledImmichFrameLogic.GetVideoAsset)
move the local cache check (using _downloadLocation, fileName and
_generalSettings.RenewImagesDuration) to run before calling
_immichApi.PlayAssetVideoAsync so we short‑circuit on cache hits; then call the
API only if cache miss or expired, wrap the returned videoResponse (and its
Stream) in a using block to ensure disposal, and on API failure fall back to
returning the cached file if present; mirror the flow used in GetImageAsset to
ensure no leaked streams and proper cache-first behavior.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@ImmichFrame.Core/Logic/PooledImmichFrameLogic.cs`:
- Around line 176-180: The cache-hit branch in PooledImmichFrameLogic is
returning a hardcoded content-type "video/mp4" for cached files (see filePath,
fileName and the caller that expects a tuple of (fileName, contentType,
Stream)), which can mismatch original responses; fix by persisting the original
content-type when first saving the file (e.g., write a companion metadata file
next to filePath like filePath + ".meta" or embed a suffix) and on cache hit
read that metadata and return the stored content-type instead of the hardcoded
"video/mp4"; also add a safe fallback to "video/mp4" if the metadata is missing
or unreadable and ensure any write/read logic is added where the file is created
and where the cached file is returned.
🧹 Nitpick comments (1)
ImmichFrame.Core/Logic/PooledImmichFrameLogic.cs (1)
190-192: Consider extracting Content-Type parsing to reduce duplication.The Content-Type extraction logic is duplicated across both branches. A small helper could improve maintainability.
♻️ Optional refactor
+ private static string GetContentType(FileResponse response, string defaultType) + { + return response.Headers.ContainsKey("Content-Type") + ? response.Headers["Content-Type"].FirstOrDefault() ?? defaultType + : defaultType; + } + private async Task<(string fileName, string ContentType, Stream fileStream)> GetVideoAsset(Guid id) { // ... cache check ... using var videoResponse = await _immichApi.PlayAssetVideoAsync(id, string.Empty); if (videoResponse == null) throw new AssetNotFoundException($"Video asset {id} was not found!"); - var contentType = videoResponse.Headers.ContainsKey("Content-Type") - ? videoResponse.Headers["Content-Type"].FirstOrDefault() ?? "video/mp4" - : "video/mp4"; + var contentType = GetContentType(videoResponse, "video/mp4");Also applies to: 208-210
|
Workflow is not running, I don't know why. |
JW-CH
left a comment
JW-CH
left a comment
There was a problem hiding this comment.
I noticed that with this change videos are no longer streamed from Immich but fully loaded into memory (or disk when caching is enabled) before being served.
While I understand this fixes Safari/iOS playback, it means the server is no longer just a proxy. For larger videos this could cause high memory usage and delayed playback start.
Is there a way to keep the original streaming behavior for non-Safari clients, or maybe forward Range requests to Immich instead?
2 participants
Fix Safari/iOS video playback by buffering videos to seekable streams
Safari requires seekable streams for video range requests. Previously, non-seekable network streams from Immich caused playback failures(error code 4 - MEDIA_ERR_SRC_NOT_SUPPORTED). Now videos are either cached to disk (when DownloadImages=true) or buffered to memory to provide seekability.
Summary by CodeRabbit
Bug Fixes
Performance
Reliability