Enable empty base class optimization on MSVC#66
Open
melak47 wants to merge 1 commit intoimneme:masterfrom
Open
Enable empty base class optimization on MSVC#66melak47 wants to merge 1 commit intoimneme:masterfrom
melak47 wants to merge 1 commit intoimneme:masterfrom
Conversation
...so that sizeof(RNG) matches expected values in tests
Demonese
added a commit
to Legacy-LuaSTG-Engine/pcg-cpp
that referenced
this pull request
Nov 6, 2025
|
I apologize for not sending this notice sooner. Mergeted into Total-Random/pcg-cpp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSVC implements empty base class optimization only as an opt-in (see https://devblogs.microsoft.com/cppblog/optimizing-the-layout-of-empty-base-classes-in-vs2015-update-2-3/).
Because of this, the tests fail on MSVC as the engines are larger than expected.
By using the attribute to opt-in to EBCO, the engines are of the expected sizes.