COMMENTS-PUBLIC: Получение комментариев к событию #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#85 Первичное исполнение без тестов.
impatient0
requested changes
May 29, 2025
Owner
impatient0
left a comment
impatient0
left a comment
There was a problem hiding this comment.
Сергей, очень хорошая реализация! Основные моменты отлично проработаны.
Оставил комментарии по логике сервиса (там вопрос по соответствию спецификации API) и взаимодействию с БД – глянь, пожалуйста, и, как разберёмся, можно будет смело мёрджить.
...ce/src/main/java/ru/practicum/explorewithme/main/service/params/PublicCommentParameters.java
Outdated
Show resolved
Hide resolved
main-service/src/main/java/ru/practicum/explorewithme/main/service/CommentServiceImpl.java
Outdated
Show resolved
Hide resolved
main-service/src/main/java/ru/practicum/explorewithme/main/service/CommentServiceImpl.java
Show resolved
Hide resolved
main-service/src/main/java/ru/practicum/explorewithme/main/service/CommentServiceImpl.java
Outdated
Show resolved
Hide resolved
main-service/src/main/java/ru/practicum/explorewithme/main/repository/CommentRepository.java
Show resolved
Hide resolved
...ce/src/main/java/ru/practicum/explorewithme/main/controller/pub/PublicCommentController.java
Outdated
Show resolved
Hide resolved
Gagarskiy-Andrey
approved these changes
May 30, 2025
impatient0
approved these changes
May 30, 2025
Owner
impatient0
left a comment
impatient0
left a comment
There was a problem hiding this comment.
Сергей, теперь всё супер! Мёрджим)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COMMENTS-PUBLIC: Получение комментариев к событию
#85
Первичное исполнение без тестов !!!