-
Notifications
You must be signed in to change notification settings - Fork 7
feat: initialize Nonce endpoint #269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
coplat
wants to merge
13
commits into
beta
Choose a base branch
from
nonce-endpoint
base: beta
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR initializes the nonce endpoint as described in OID4CI's draft 15 specification. . This is vital as a means to prevent replay attacks during credential requests. Nonces are generated when a post request is made to the
/oid4vci/nonceendpoint, returning a unique and freshc_nonce.This
c_noncemust then be included in the proof of a CredentialRequest made to the issuer. If that nonce has already been redeemed or does not exist, the credential request is denied.If it is valid, the c_nonce is then marked as redeemed and can no longer be reused.
This PR initializes the nonce endpoint which generates the nonce, and validates the nonce when a credential request is made within the API layer. Further, the nonce commands, events, errors and corresponding aggregate are also initialized within this PR.
Links to any relevant issues
How the change has been tested
Existing tests have been updated to include nonces. Nonce endpoint has been added to the postman collection for
c_noncegeneration.Definition of Done checklist
Add an
xto the boxes that are relevant to your changes.