Open
Conversation
Contributor
|
Can you please mark this as a draft? Also please run |
Contributor
|
@kdxcxs I have just had a bit of a look at three.js. As far as I can tell, it uses the HTML Canvas element, if I saw that correctly, am I right? If so, using it with impress should be fairly easy. That wouldn't even really require a plugin, right? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduction
It's a plugin makes three.js works with impress.js, which allows like 3d models to be added in impress.js canvas with all other feat from three.js.
This plugin is still in a very early stage, please do not merge. It's a cool feat for me, but I'm not sure if it's suitable for impess.js, so I opened this pr for further discution. The features are not fully implemented yet, but I've wrote a simple example in
examples/three/index.html.TODO
Issues
Ending
Here's still a lot not mentioned above, and I think here could be a lot changes to be made in impress.js, so I choose to contact you guys as early as possible to make it right. Or if this is plugin not what impress.js wanted, it's ok to reject and close this pr.