Skip to content

Field to toggle auth request signing#28

Open
kadaji wants to merge 3 commits intoimsweb:mainfrom
Canusia:main
Open

Field to toggle auth request signing#28
kadaji wants to merge 3 commits intoimsweb:mainfrom
Canusia:main

Conversation

@kadaji
Copy link
Copy Markdown

@kadaji kadaji commented May 24, 2024

By default the auth request signing field is set to False. Added a checkbox to allow configuring the setting.

Comment thread sp/admin.py
"fields": (
"contact_name",
"contact_email",
"authn_requests_signed",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be down in the "Advanced" group below.

Comment thread sp/models.py
contact_name = models.CharField(max_length=100)
contact_email = models.EmailField(max_length=100)

authn_requests_signed = models.BooleanField(
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor quibble, but can you put this down by the logout_request_signed and logout_response_signed fields?

Comment thread sp/models.py Outdated
"security": {
"wantAttributeStatement": self.require_attributes,
"metadataValidUntil": self.certificate_expires,
"authnRequestsSigned": self.,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you missed something here 😄

Comment thread sp/views.py

def metadata(request, **kwargs):
idp = get_request_idp(request, **kwargs)
print(idp.sp_settings)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants