Use Poison atom keys#58
Open
jwarlander wants to merge 2 commits intoinaka:masterfrom
Open
Conversation
|
Great to drop a dependency, but this triggered a question around dynamic atoms for me, I'll raise a n issue. |
Author
|
@cloud8421, it should behave the same as the code it replaces (https://github.com/devinus/poison/blob/master/lib/poison/parser.ex#L113-L114) - eg. yes, it will create potentially infinite atoms until the VM crashes. As mentioned in #57, this can't really be changed until there's a new major release, as it would potentially break existing use cases, so I just went for eliminating a dependency for now. |
|
@jwarlander thanks, I raised a separate issue at #59 about it. Yes, it definitely needs a deprecation/upgrade path if it gets changed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of manually converting JSON keys to atoms in
Dayron.HTTPoisonAdapter, eliminate a dependency and some code by using thekeys: :atomsoption for Poison when decoding.