Process command-line files according to config settings #568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, command-line files were forced to be processed sequentially, regardless of any `parallel` setting. Now the files are converted to elvis_files and included in the config for regular processing.
Author
|
@elbrujohalcon first stab. Lifted the bits in |
elbrujohalcon
requested changes
Mar 31, 2022
Member
elbrujohalcon
left a comment
elbrujohalcon
left a comment
There was a problem hiding this comment.
Your approach is fine with me. But if you want to create elvis_file:from_filename/1, that's even better… of course.
| ok -> ok | ||
| end; | ||
| _ -> | ||
| lists:map(fun(F) -> rock_one_song(F, Config) end, Files) |
Member
There was a problem hiding this comment.
Shouldn't we remove rock_one_song/2 entirely, too?
Author
There was a problem hiding this comment.
Yes, thought i had! Pushed commit with that removed.
elbrujohalcon
approved these changes
Sep 16, 2024
evgenii-terekhov
force-pushed
the
2600Hz
branch
from
26ef5f2 to
527fbc9
Compare
paulo-ferraz-oliveira
approved these changes
Apr 23, 2025
Collaborator
paulo-ferraz-oliveira
left a comment
paulo-ferraz-oliveira
left a comment
There was a problem hiding this comment.
CI's failing, but the general direction is good.
evgenii-terekhov
force-pushed
the
2600Hz
branch
from
527fbc9 to
26ef5f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, command-line files were forced to be processed
sequentially, regardless of any
parallelsetting.Now the files are converted to elvis_files and included in the config
for regular processing.
Addresses #567