Adapt to new elvis_core configuration validation
#596
Conversation
CI already does this, and furthermore, these days an invalid config. will not allow for a proper loading
By default rebar3 test already runs in profile `test`
| - shell: bash | ||
| run: rebar3 as test test |
There was a problem hiding this comment.
Explained in commit message: test (the command) already runs in profile test, by default, so this is simply duplicating what is already done above.
There was a problem hiding this comment.
Are you sure? I know that rebar3 ct uses the test profile by default, but test is a custom alias… how does rebar3 know that it has to run it on the test profile? 🤔
There was a problem hiding this comment.
You are right, it is not ct. Why would it be required to run test as test, though?
There was a problem hiding this comment.
I reverted this change. Even if it takes a while longer, it's maybe not inocuous that it's there 😄
| [{elvis_core, | ||
| {git, "https://github.com/inaka/elvis_core.git", {branch, "fix/config-parse-validate"}}}, |
There was a problem hiding this comment.
elvis_core's linked pull request)
... as explained in the added comment
Description
We tweak Elvis, without changing its interface, to adapt to the most recent changes to
elvis_core, at inaka/elvis_core#515.elvis_corepull request resulted in a new version (it's possible until then we might need to keep implementing on top of this pull request, we'll see!)Further considerations
I expect CI to fail at least at the very end, since we're using a branch in a
rebar.configdep. and Elvis doesn't like it by default (or rather, per its configuration). ℹ️ as expected: https://github.com/inaka/elvis/actions/runs/16334784491/job/46144600609#step:8:13