Skip to content

fix: modify cache key when per_page is zero, WEB-889 #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pleary merged 1 commit into from
Jan 5, 2026
Merged

fix: modify cache key when per_page is zero, WEB-889 #556

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,8 @@ const util = class util {
cacheableParams.qualityGrade = queryDup.quality_grade ? queryDup.quality_grade : null;
cacheableParams.spam = queryDup.spam ? queryDup.spam : null;
cacheableParams.captive = queryDup.captive ? queryDup.captive : null;
cacheableParams.perPage = queryDup.per_page ? queryDup.per_page : null;
cacheableParams.perPage = ( _.isNumber( queryDup.per_page ) || queryDup.per_page )
? queryDup.per_page : null;
cacheableParams.order = queryDup.order ? queryDup.order : null;
cacheableParams.orderBy = queryDup.order_by ? queryDup.order_by : null;
cacheableParams.returnBounds = queryDup.return_bounds ? queryDup.return_bounds : null;
Expand Down
4 changes: 4 additions & 0 deletions test/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,10 @@ describe( "util", ( ) => {
expectParamInCacheKey( "place_id", 1, "placeID" );
} );

it( "allows queries with numeric per_page value of 0 to be cached for obs search", ( ) => {
expectParamInCacheKey( "per_page", 0, "perPage" );
} );

it( "does not allow queries with place_id to be cached for obs search when logged in", ( ) => {
const req = {
query: {
Expand Down