Skip to content

Fix proguard compile error caused by metadata-extractor module #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
finnholland wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix proguard compile error caused by metadata-extractor module #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ dependencies {
implementation "com.facebook.react:react-native:+"
implementation 'androidx.exifinterface:exifinterface:1.1.0'
implementation 'it.sephiroth.android.exif:library:+'
implementation 'com.github.drewnoakes:metadata-extractor:321551df00'
implementation 'com.github.drewnoakes:metadata-extractor:2.19.0'
Copy link

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the JitPack reference 'com.github.drewnoakes:metadata-extractor' with a version number is problematic. The metadata-extractor library is published to Maven Central and should be referenced as 'com.drewnoakes:metadata-extractor:2.19.0' instead. The 'com.github.*' group ID is used by JitPack for building from GitHub, but this library has official Maven Central releases that should be preferred.

Suggested change
implementation 'com.github.drewnoakes:metadata-extractor:2.19.0'
implementation 'com.drewnoakes:metadata-extractor:2.19.0'

Copilot uses AI. Check for mistakes.
Copy link
Member

@jtklein jtklein Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@budowski do you remember any reason why we pinned this dependency to this specific commit (drewnoakes/metadata-extractor@321551df00), and are not using the maven version here?

// From node_modules
}

Expand Down