Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
♻️ Create model for PCGC and DS studies
Re-do of #13 :
This PR builds upon a previous KF study test model (see #8). This model uses a more complex study that covers more DS entities than the previous example, so that we can model dataservice entirely.
Also included, is adding a DAG for this study.
Some key decisions/points:
This model focuses on mirroring dataservice entities into the model. Therefore, transformations are minimal. The key focus is getting the structure and flow right which we can then adjust later
The stable and access models are also minimal as they were not the focus. These models are filled in to give a proof of concept, but will need to be updated to match the final access model
Comments have been added to fields/entites that could be improved or removed entirely from the model, as they will not be needed in any upstream models
Visibility has not been applied but eventually should - as all dataservice records are not eligible to flow into access models. This will need to be further discussed.
All tables have been named using this format: program_study_stage_a . In this case, the idea is this model would eventually be used for all existing dataservice studies. Rather than one model per study, there would be one model for all dataservice studies. With that in mind, I've named models as such: kf_ds_src_, kf_ds_int_, kf_ds_stable_ . With this naming, we can use this model as a base and add more studies without needing to make major changes to table names/docs.
Documentation has been updated to fit this model - it does deviate from the documentation from the initial test study
Closes (issue identifier)
Type of change
Please delete options that are not relevant.
to not work as expected)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details for
your test configuration
Test Configuration:
Checklist
Please check all of the items below before merging this pull request. If an
item in the list below does not need to be completed, please indicate the
reason why.
the start of each script
works
sqlfluff fixon tables that are created or modified in this PR.