Skip to content

Conversation

@adamdickmeiss
Copy link
Contributor

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modernizes the Debian packaging by upgrading from debhelper version 7/9 to debhelper 13, following the new debhelper-compat build dependency pattern.

Changes:

  • Updated Build-Depends to use debhelper-compat (= 13) instead of the old debhelper (>= 7)
  • Removed the deprecated debian/compat file
  • Added debian/not-installed file to document intentionally unpackaged files

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
debian/control Updated Build-Depends to use debhelper-compat (= 13) format
debian/compat Removed deprecated compat file (replaced by debhelper-compat in control)
debian/not-installed Added file to document uninstalled man pages and libtool archives

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -0,0 +1,2 @@
usr/share/man/man*/*
Copy link

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pattern 'usr/share/man/man*/*' in the not-installed file will exclude ALL man pages from being installed. However, the package has multiple .manpages files (debian/libyaz5-dev.manpages, debian/yaz.manpages, debian/yaz-icu.manpages, debian/yaz-illclient.manpages) that explicitly list man pages to be included in specific packages. This creates a conflict where the man pages are being explicitly installed via .manpages files but then excluded via not-installed. Either remove this pattern from not-installed to allow the man pages to be installed as configured, or remove the .manpages files if man pages should not be included.

Suggested change
usr/share/man/man*/*

Copilot uses AI. Check for mistakes.
@adamdickmeiss adamdickmeiss merged commit 00bb1c5 into master Jan 13, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants