Open
Conversation
Contributor
littleskunk
commented
May 17, 2017
littleskunk
commented
- Closes xml2js outdated -> Error: Text data outside of root node on invalid router response #31
Owner
|
Thank you for this! Do tests pass after update? |
Contributor
Author
|
I was not able to execute the tests with and without my change. |
Owner
|
For me 3 of 4 tests pass without this change, and with change only 1 of 4 does pass. As far as I know there were some API changes in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.