Complete project refactor to typescript#44
Open
kaden-sharpin wants to merge 9 commits intoindutny:masterfrom
Open
Complete project refactor to typescript#44kaden-sharpin wants to merge 9 commits intoindutny:masterfrom
kaden-sharpin wants to merge 9 commits intoindutny:masterfrom
Conversation
…added authors and scripts
|
As a tip, you could release this on npm as a scoped package by renaming it to "@kaden-sharpin/nat-upnp", making it easier to depend upon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know that this repo is long dead and this pull request will never be merged.
I made this fork for myself and thought I would try and share it.
Essentially, I completely:
Big credit to @SimplyLinn for creating the type declarations that I worked off and implemented.
To install my fork in your projects:
npm i git+https://github.com/kaden-sharpin/node-nat-upnp.git