Add URLSearchParams.prototype.sort() #135
Conversation
| assert.deepEqual(url.searchParams.getAll('b'), ['3']); | ||
| assert.equal(url.href, 'http://example.com/?a=1&b=3&c=1'); | ||
|
|
||
| url.href = 'http://example.com?c=1&a=2&a=4&b=3'; |
There was a problem hiding this comment.
Not sure if these tests belong in this section.
|
The problem with the patch as-is is that several browser implementations shipped a version without sort(). That means very old browsers would use the full polyfill with sort(), and very new browsers don't need the polyfill. But in between there are browsers that would have URLSearchParams but no sort() (such as the current versions of Chrome) To add this safely it'll be necessary to include a polyfill for a native URLSearchParams without sort(). |
|
Yes, good point. I can look into this when I have the time. |
|
Thanks! I greatly appreciate the PR submission and especially the inclusion of tests. |
|
Also, obviously, CI running on PRs would catch this, but I haven't been spending any time on this project lately. :( |
2 participants
https://url.spec.whatwg.org/#dom-urlsearchparams-sort