Skip to content

ID-45: execution scripts#287

Draft
karlnaden wants to merge 15 commits intomainfrom
id45-execution-scripts
Draft

ID-45: execution scripts#287
karlnaden wants to merge 15 commits intomainfrom
id45-execution-scripts

Conversation

@karlnaden
Copy link
Copy Markdown
Contributor

DRAFT DETAILS

This is still a draft and will remain so until the inferno_core PR for scripted execution and the smart-app-launch PR are merged and released as gems.

To test locally in the meantime, it is recommend to:

  • check out the inferno_core branch locally.
  • Update the Gemfile inferno-core gem command to use path: '<path to inferno-core on your system>'

This will allow you both to execute scripts within the smart-app-launch-test-kit directory and see the UI.

NOTE: the execution scripts github workflow will fail because of this problem until the inferno-core gem is released!

Summary

Add support for execution scripts, including commands for performing authorizations and launches from the Inferno Reference Server using Selenium. Includes

  • Upgrading to inferno_core version with execution script support
  • Adding standard features, such as the github workflow that executes scripts on PRs, a rake task for executing all execution_scripts, and an update to the gemspec to include execution scripts within the gem.
  • create execution scripts for the server tests against the reference server
  • (TODO) additional scripts covering more smart versions

Additional Changes:

  • Updated gem authors

Testing Guidance

  • Start the us_core_test_kit services and main Inferno process in Ruby developer mode.
  • Run the rake task that executes all scripts: be rake execute_scripts:run_all. They should all pass. You can also find the session URLs and look at them in the UI to confirm that all the tests actually passed. NOTES:
    • This will take a long time, probably at least an hour. The local validator tends to get bogged down, so you could also run the 7 scripts individually, restarting the services between every two or three to keep it fresh.
    • There are failures which are currently expected, including
      • (all versions) Immunization terminology issue - I don't think we can resolve without breaking g10, so leaving
      • (v8.0.0) snomed version issues causing Patient, Encounter, and MedicationDispense failures - related to a validator issue that is being worked on (these will help with preventing regressions due to that fix)
      • (all versions that check them) some optional searches on the Condition profiles and DocumentReference ADI profile are skipped because the element is not currently demonstrated because it isn't must support (could fix later)
      • (all versions that check them) some optional searches on Goal and CareTeam fail because they aren't supported by the reference server at this time
  • Ideally, check the results in a deployed environment before merging by deploying to QA and the same rake task executed against QA prior to approval be rake execute_scripts:run_all INFERNO_BASE_URL=https://inferno-qa.healthit.gov/suites

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant