-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add standalone Reactotron server and update dependencies #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
joshuayoes
wants to merge
6
commits into
main
Choose a base branch
from
reactotron-macos-server
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c8d0246
feat: add standalone Reactotron server and update dependencies
joshuayoes 66253d3
feat: enhance Reactotron server connection handling and UI updates
joshuayoes 34dcd67
fix: improve user shell detection in AppDelegate.mm
joshuayoes a6f3324
refactor: use constant for Reactotron server bundle name and improve …
joshuayoes ff0b995
refactor: streamline logging checks in AppDelegate.mm
joshuayoes 6ed274f
feat: integrate Reactotron server management into the app
joshuayoes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| *.bundle.js |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| // Generally, this file can be left alone as-is. | ||
| // Make your changes in the IRReactotronServer.mm file. | ||
| #import <Foundation/Foundation.h> | ||
| #import <AppSpec/AppSpec.h> | ||
|
|
||
| @interface IRReactotronServer : NativeIRReactotronServerSpecBase <NativeIRReactotronServerSpec> | ||
| @end | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| #import "IRReactotronServer.h" | ||
|
|
||
| @implementation IRReactotronServer RCT_EXPORT_MODULE() | ||
|
|
||
| /** | ||
| * Returns the path to the bundled Reactotron server script. | ||
| */ | ||
| - (NSString *)getBundlePath { | ||
| NSURL *bundleURL = [[NSBundle mainBundle] URLForResource:@"standalone-server.bundle" withExtension:@"js"]; | ||
| if (bundleURL) { | ||
| NSLog(@"✓ Found Reactotron server bundle at: %@", bundleURL.path); | ||
| return bundleURL.path; | ||
| } | ||
|
|
||
| NSLog(@"⚠️ Reactotron server bundle not found in main bundle"); | ||
| return nil; | ||
| } | ||
|
|
||
| // Required by TurboModules. | ||
| - (std::shared_ptr<facebook::react::TurboModule>)getTurboModule:(const facebook::react::ObjCTurboModule::InitParams &)params { | ||
| return std::make_shared<facebook::react::NativeIRReactotronServerSpecJSI>(params); | ||
| } | ||
|
|
||
| @end | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| import type { TurboModule } from "react-native" | ||
| import { TurboModuleRegistry } from "react-native" | ||
|
|
||
| export interface Spec extends TurboModule { | ||
| getBundlePath(): string | null | ||
| } | ||
|
|
||
| export default TurboModuleRegistry.getEnforcing<Spec>("IRReactotronServer") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: since metro doesn't touch the server bundle, unfortunately this needs to be a native module :(