-
Notifications
You must be signed in to change notification settings - Fork 0
Replace MMKV with C file writing #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
request: remove Line 29 in 7263835
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things seem to be looking pretty good. I tried quitting and reload and it seemed to retrieve some info from reloading. It didn't persist the logs but I'm not sure that is necessary.
Replace-MMKV-with-C-file.mov
I am noticing that even without the temp file, it seems to be persisting some client info when I quit and reload?
Screen.Recording.2025-10-10.at.3.08.32.PM.mov
| id: "reactotron", | ||
| }) | ||
| const PERSISTED_KEY = "global-state.json" | ||
| const STORAGE_DIR = "/tmp/reactotron/filestorage/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: on windows, this would be better put temp in C:\Users\Username\AppData\Local\Temp. But for now this is okay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should be able to utilize std::filesystem::path temp = std::filesystem::temp_directory_path(); That'll get the path Josh is talking about (and also should be good on macOS also)
https://en.cppreference.com/w/cpp/filesystem/temp_directory_path.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this evaluates to /var/folders/09/c8x8x89n75n02qyqvvybl54h0000gp/T/ on mac, are we alright with that? Seems fine to me, because i don't think people are really going to care about it, but figured i'd bring that up before i commit changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also @joshuayoes i believe the client information that you're seeing persisted is coming from the standalone-server
What does this PR do?
What GitHub issues does this PR fix?
How to verify this code works?
reactotron-macos setup for this PR
gh pr checkout 57npm installnpm run podnpm run startnpm run macosStep by step of how to test this PR
Windows
This is not tested on windows...