Skip to content

Conversation

@pedroanastacio
Copy link
Member

Description

  • When a user canceled a transaction and created a transaction identical to the canceled one, generating a transaction with the same hash, there was an error in the API that did not send the transaction to the chain.

Summary

  • Adds canceled status to the array of ignored statuses in the transaction search query by hash
  • Adds order by to query to get the newest transaction with de provided hash
  • Adds test to ensure that a canceled transaction does not interfere with the sending of another transaction with the same hash

Checklist

  • I reviewed my PR code before submitting
  • I ensured that the implementation is working correctly and did not impact other parts of the app
  • I mentioned the PR link in the task

Copy link
Member

@guimroque guimroque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Production Promotion Checklist

This PR is being merged to main. Please verify the items below:

🔒 Security

  • No secrets/credentials exposed in code
  • No staging/development URLs hardcoded
  • No debug flags enabled

✅ Quality

  • Build passed on staging
  • Tests passed on staging
  • Code was reviewed on staging

🔄 Integrity

✅ Branch main is synchronized

⚠️ Issues Found

🟡 Warnings (manual review)

  • Test domain: .test em packages/api/src/tests/transaction.tests.ts:422

Copy link
Member

@guimroque guimroque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Validation passed. PR approved for merge to main.

@guimroque guimroque merged commit 3485e47 into main Jan 23, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants