Authorization refactor

.gitignore

@@ -413,5 +413,6 @@ appsettings.json
 # MacOs
 .DS_Store
 
+
 #Claude
 CLAUDE.md

backend/ECondo.Api/Controllers/PropertyController.cs

@@ -2,12 +2,11 @@
 using ECondo.Application.Commands.Properties.Create;
 using ECondo.Application.Commands.Properties.Delete;
 using ECondo.Application.Commands.Properties.Update;
-using ECondo.Application.Data;
 using ECondo.Application.Data.Property;
 using ECondo.Application.Queries.Properties.GetAll;
 using ECondo.Application.Queries.Properties.GetById;
 using ECondo.Application.Queries.Properties.GetForUser;
-using ECondo.Application.Queries.Properties.GetInBuilding;
+using ECondo.Application.Queries.Properties.GetInEntrance;
 using MediatR;
 using Microsoft.AspNetCore.Authorization;
 using Microsoft.AspNetCore.Mvc;
@@ -19,15 +18,15 @@ namespace ECondo.Api.Controllers;
 public class PropertyController(ISender sender) : ControllerBase
 {
     [Authorize]
-    [HttpGet(nameof(GetPropertiesInBuilding))]
+    [HttpGet(nameof(GetPropertiesInEntrance))]
     [ProducesResponseType(StatusCodes.Status200OK,
         Type = typeof(PagedListResponse<PropertyOccupantResult>))]
     [ProducesResponseType(StatusCodes.Status400BadRequest,
         Type = typeof(HttpValidationProblemDetails))]
     [ProducesResponseType(StatusCodes.Status401Unauthorized)]
     public async Task<IResult>
-        GetPropertiesInBuilding(
-            [FromQuery] GetPropertiesInBuildingQuery request)
+        GetPropertiesInEntrance(
+            [FromQuery] GetPropertiesInEntranceQuery request)
     {
         var result = await sender.Send(request);
 

backend/ECondo.Api/Extensions/ApiErrorExtension.cs

@@ -1,6 +1,6 @@
 using Microsoft.AspNetCore.Http.HttpResults;
 using System.Diagnostics;
-using ECondo.Domain.Shared;
+using ECondo.SharedKernel.Result;
 
 namespace ECondo.Api.Extensions;
 public static class ApiErrorExtension

backend/ECondo.Api/Extensions/CustomResults.cs

@@ -1,4 +1,4 @@
-using ECondo.Domain.Shared;
+using ECondo.SharedKernel.Result;
 
 namespace ECondo.Api.Extensions;
 

backend/ECondo.Api/Extensions/PagedListExtension.cs

@@ -1,4 +1,4 @@
-using ECondo.Domain.Shared;
+using ECondo.SharedKernel.Collections;
 
 namespace ECondo.Api.Extensions;
 

backend/ECondo.Api/Extensions/ResultExtensions.cs

@@ -1,4 +1,4 @@
-using ECondo.Domain.Shared;
+using ECondo.SharedKernel.Result;
 
 namespace ECondo.Api.Extensions;
 

backend/ECondo.Application.IntegrationTests/Commands/Buildings/AcceptPropertyInvitationCommandHandlerTests.cs

@@ -1,15 +1,13 @@
 using ECondo.Application.Commands.PropertyOccupants.AcceptInvitation;
 using ECondo.Application.Repositories;
 using ECondo.Application.Services;
-using ECondo.Domain;
 using ECondo.Domain.Buildings;
-using ECondo.Domain.Shared;
 using ECondo.Domain.Users;
 using ECondo.Infrastructure.Contexts;
+using ECondo.SharedKernel.Result;
 using FluentAssertions;
 using Microsoft.EntityFrameworkCore;
 using NSubstitute;
-using Xunit;
 
 namespace ECondo.Application.IntegrationTests.Commands.PropertyOccupants.AcceptInvitation;
 

backend/ECondo.Application.IntegrationTests/Commands/Buildings/AddOccupantToPropertyCommandHandlerTests.cs

@@ -1,22 +1,18 @@
 using ECondo.Application.Commands.PropertyOccupants.AddToProperty;
-using ECondo.Application.Events.PropertyOccupant;
 using ECondo.Application.Repositories;
-using ECondo.Domain;
 using ECondo.Domain.Buildings;
-using ECondo.Domain.Shared;
 using ECondo.Infrastructure.Contexts;
+using ECondo.SharedKernel.Result;
 using FluentAssertions;
 using MediatR;
 using Microsoft.EntityFrameworkCore;
 using NSubstitute;
-using Xunit;
 
 namespace ECondo.Application.IntegrationTests.Commands.PropertyOccupants.AddToProperty;
 
 public class AddOccupantToPropertyCommandHandlerTests
 {
     private readonly IApplicationDbContext _dbContext;
-    private readonly IPublisher _publisher;
     private readonly AddOccupantToPropertyCommandHandler _handler;
 
     public AddOccupantToPropertyCommandHandlerTests()
@@ -26,8 +22,8 @@ public AddOccupantToPropertyCommandHandlerTests()
             .Options;
 
         _dbContext = new ECondoDbContext(options);
-        _publisher = Substitute.For<IPublisher>();
-        _handler = new AddOccupantToPropertyCommandHandler(_dbContext, _publisher);
+        var publisher = Substitute.For<IPublisher>();
+        _handler = new AddOccupantToPropertyCommandHandler(_dbContext, publisher);
     }
 
     [Fact]

backend/ECondo.Application.IntegrationTests/Commands/Buildings/ConnectStripeAccountCommandHandlerTests.cs

@@ -1,17 +1,16 @@
 using ECondo.Application.Commands.Payment.ConnectStripeAccount;
 using ECondo.Application.Repositories;
 using ECondo.Application.Services;
-using ECondo.Domain;
 using ECondo.Domain.Buildings;
-using ECondo.Domain.Shared;
 using ECondo.Infrastructure.Contexts;
+using ECondo.SharedKernel.Result;
 using FluentAssertions;
 using Microsoft.EntityFrameworkCore;
 using NSubstitute;
-using Xunit;
 
 namespace ECondo.Application.IntegrationTests.Commands.Payment.ConnectStripeAccount;
 
+
 public class ConnectStripeAccountCommandHandlerTests
 {
     private readonly IApplicationDbContext _dbContext;
@@ -33,12 +32,11 @@ public ConnectStripeAccountCommandHandlerTests()
     public async Task Handle_ShouldConnectStripeAccount_WhenValid()
     {
         // Arrange
-        var buildingId = Guid.NewGuid();
+        var entranceId = Guid.NewGuid();
         var entrance = new Entrance
         {
-            Id = Guid.NewGuid(),
-            BuildingId = buildingId,
-            Number = "Entrance1"
+            Id = entranceId,
+            Number = "1",
         };
 
         _dbContext.Entrances.Add(entrance);
@@ -52,8 +50,7 @@ public async Task Handle_ShouldConnectStripeAccount_WhenValid()
             .Returns(onboardingLink);
 
         var command = new ConnectStripeAccountCommand(
-            buildingId,
-            "Entrance1",
+            entranceId,
             "https://example.com/return"
         );
 
@@ -74,12 +71,11 @@ public async Task Handle_ShouldConnectStripeAccount_WhenValid()
     public async Task Handle_ShouldUpdateDatabaseCorrectly_WhenStripeAccountConnected()
     {
         // Arrange
-        var buildingId = Guid.NewGuid();
+        var entranceId = Guid.NewGuid();
         var entrance = new Entrance
         {
-            Id = Guid.NewGuid(),
-            BuildingId = buildingId,
-            Number = "Entrance1"
+            Id = entranceId,
+            Number = "1",
         };
 
         _dbContext.Entrances.Add(entrance);
@@ -93,8 +89,7 @@ public async Task Handle_ShouldUpdateDatabaseCorrectly_WhenStripeAccountConnecte
             .Returns(onboardingLink);
 
         var command = new ConnectStripeAccountCommand(
-            buildingId,
-            "Entrance1",
+            entranceId,
             "https://example.com/return"
         );
 

backend/ECondo.Application.IntegrationTests/Commands/Buildings/CreateBillCommandHandlerTests.cs

@@ -1,15 +1,13 @@
 using ECondo.Application.Commands.Payment.CreateBill;
 using ECondo.Application.Repositories;
 using ECondo.Application.Services;
-using ECondo.Domain;
 using ECondo.Domain.Buildings;
 using ECondo.Domain.Payments;
-using ECondo.Domain.Shared;
 using ECondo.Infrastructure.Contexts;
+using ECondo.SharedKernel.Result;
 using FluentAssertions;
 using Microsoft.EntityFrameworkCore;
 using NSubstitute;
-using Xunit;
 
 namespace ECondo.Application.IntegrationTests.Commands.Payment.CreateBill;
 
@@ -34,11 +32,10 @@ public CreateBillCommandHandlerTests()
     public async Task Handle_ShouldCreateBill_WhenValid()
     {
         // Arrange
-        var buildingId = Guid.NewGuid();
         var entrance = new Entrance
         {
             Id = Guid.NewGuid(),
-            BuildingId = buildingId,
+            BuildingId = Guid.NewGuid(),
             Number = "Entrance1"
         };
 
@@ -48,8 +45,7 @@ public async Task Handle_ShouldCreateBill_WhenValid()
         _userContext.UserId.Returns(Guid.NewGuid());
 
         var command = new CreateBillCommand(
-            buildingId,
-            "Entrance1",
+            entrance.Id,
             "Test Bill",
             "Test Description",
             100.0m,
@@ -65,7 +61,9 @@ public async Task Handle_ShouldCreateBill_WhenValid()
         // Assert
         result.IsOk().Should().BeTrue();
 
-        var createdBill = await _dbContext.Bills.FirstOrDefaultAsync(b => b.Title == "Test Bill");
+        var createdBill = await _dbContext
+            .Bills
+            .FirstOrDefaultAsync(b => b.Title == "Test Bill");
         createdBill.Should().NotBeNull();
         createdBill!.Amount.Should().Be(100.0m);
         createdBill.IsRecurring.Should().BeFalse();
@@ -75,11 +73,10 @@ public async Task Handle_ShouldCreateBill_WhenValid()
     public async Task Handle_ShouldGeneratePayments_ForOneTimeBill()
     {
         // Arrange
-        var buildingId = Guid.NewGuid();
         var entrance = new Entrance
         {
             Id = Guid.NewGuid(),
-            BuildingId = buildingId,
+            BuildingId = Guid.NewGuid(),
             Number = "Entrance1"
         };
 
@@ -105,8 +102,7 @@ public async Task Handle_ShouldGeneratePayments_ForOneTimeBill()
         _userContext.UserId.Returns(Guid.NewGuid());
 
         var command = new CreateBillCommand(
-            buildingId,
-            "Entrance1",
+            entrance.Id,
             "One-Time Bill",
             "Test Description",
             200.0m,
@@ -122,7 +118,12 @@ public async Task Handle_ShouldGeneratePayments_ForOneTimeBill()
         // Assert
         result.IsOk().Should().BeTrue();
 
-        var payments = await _dbContext.Payments.Where(p => p.BillId == result.ToSuccess().Data).ToListAsync();
+        var payments = await _dbContext
+            .Payments
+            .Where(p => 
+                p.BillId == result.ToSuccess().Data)
+            .ToListAsync();
+
         payments.Should().HaveCount(2);
         payments.All(p => p.AmountPaid == 100.0m).Should().BeTrue();
     }
@@ -131,11 +132,10 @@ public async Task Handle_ShouldGeneratePayments_ForOneTimeBill()
     public async Task Handle_ShouldNotGeneratePayments_ForRecurringBill()
     {
         // Arrange
-        var buildingId = Guid.NewGuid();
         var entrance = new Entrance
         {
             Id = Guid.NewGuid(),
-            BuildingId = buildingId,
+            BuildingId = Guid.NewGuid(),
             Number = "Entrance1"
         };
 
@@ -145,8 +145,7 @@ public async Task Handle_ShouldNotGeneratePayments_ForRecurringBill()
         _userContext.UserId.Returns(Guid.NewGuid());
 
         var command = new CreateBillCommand(
-            buildingId,
-            "Entrance1",
+            entrance.Id,
             "Recurring Bill",
             "Test Description",
             300.0m,
@@ -162,7 +161,11 @@ public async Task Handle_ShouldNotGeneratePayments_ForRecurringBill()
         // Assert
         result.IsOk().Should().BeTrue();
 
-        var payments = await _dbContext.Payments.Where(p => p.BillId == result.ToSuccess().Data).ToListAsync();
+        var payments = await _dbContext
+            .Payments
+            .Where(p => 
+                p.BillId == result.ToSuccess().Data)
+            .ToListAsync();
         payments.Should().BeEmpty();
     }
 }

backend/ECondo.Application.IntegrationTests/Commands/Buildings/CreatePaymentIntentCommandHandlerTests.cs

@@ -1,14 +1,12 @@
 using ECondo.Application.Commands.Payment.CreateIntent;
 using ECondo.Application.Repositories;
 using ECondo.Application.Services;
-using ECondo.Domain;
 using ECondo.Domain.Buildings;
-using ECondo.Domain.Shared;
 using ECondo.Infrastructure.Contexts;
+using ECondo.SharedKernel.Result;
 using FluentAssertions;
 using Microsoft.EntityFrameworkCore;
 using NSubstitute;
-using Xunit;
 
 namespace ECondo.Application.IntegrationTests.Commands.Payment.CreateIntent;
 

backend/ECondo.Application.IntegrationTests/Commands/Buildings/CreateProfileCommandHandlerTests.cs

@@ -1,14 +1,12 @@
 using ECondo.Application.Commands.Profiles.Create;
 using ECondo.Application.Repositories;
 using ECondo.Application.Services;
-using ECondo.Domain.Profiles;
-using ECondo.Domain.Shared;
 using ECondo.Domain.Users;
 using ECondo.Infrastructure.Contexts;
+using ECondo.SharedKernel.Result;
 using FluentAssertions;
 using Microsoft.EntityFrameworkCore;
 using NSubstitute;
-using Xunit;
 
 namespace ECondo.Application.IntegrationTests.Commands.Profiles.Create;