Fully separate schema: common vs tenant#117
Open
mjsteckel wants to merge 5 commits intoinfluitive:masterfrom
Open
Fully separate schema: common vs tenant#117mjsteckel wants to merge 5 commits intoinfluitive:masterfrom
mjsteckel wants to merge 5 commits intoinfluitive:masterfrom
Conversation
1) maintain separation between "common" and tenant schemas (means that "common" tables are not also in the tenant schema!) 2) taks to process all tenants or a single tenant 3) support for per tenant migrations (potentially scary) 4) changed default so that db:migrate does NOT run apartment migrations.
schema before executing any tenant migration.
schema search path.
Contributor
Contributor
|
I don't actually see any indication of splitting out the Things to think about:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consider this a proof of concept and not a formal pull request. I am sure that there are cleaner ways of accomplishing the functionality that I've implemented.
There is work left to do to clean things up, for instance apartment:load is missing. Also, tests haven't been updated.