Fix schema migrations for tenants using sql creation#156
Merged
bradrobertson merged 1 commit intoinfluitive:developmentfrom Jul 8, 2014
Merged
Fix schema migrations for tenants using sql creation#156bradrobertson merged 1 commit intoinfluitive:developmentfrom
bradrobertson merged 1 commit intoinfluitive:developmentfrom
Conversation
Remove hardcoded reference to 'bithub_development'
Contributor
Author
|
@bradrobertson, @vdragsic: Any thoughts on merging this in relation to #151. I hate to be pointing to my fork and it seems to have the use_sql option in the README and not have this feature working correctly with migrations due to a small oversight in the code. |
Contributor
|
These changes make sense to me. I'll be honest, as I've mentioned, I've never played around with this sql adapter so I'm going on your information that this works for you. |
bradrobertson
added a commit
that referenced
this pull request
Jul 8, 2014
Fix schema migrations for tenants using sql creation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove hardcoded reference to 'bithub_development'
I know there is still discussion on the best way to handle excluded models with the tenant creation from SQL feature here. However, in the meantime it would be great to at least fix this error so the development does not have fatal database messages and works for tenant migrations.
I would have liked to have added some regression tests but I am not sure how to create specs for this code-base. I am open to suggestions. I real integration test would have been to run a new migration somehow and show that it gets recorded in the tenant schema_migrations. I am open to ideas.