Performance optimisation. Do not query database for existence of schema upon every call

[NielsKSchjoedt]

#288

[mikecmpbll]

thanks! what are the implications of this?

Can you verify what happens if you straight up remove that line and try to connect to an invalid tenant?

[NielsKSchjoedt]

It removes the absurd amount of calls to:

  SELECT COUNT(*)
     FROM pg_namespace
     WHERE nspname = ?

No exception is raised though, if you set the path to something like Apartment::Tenant.switch!('sdgjkdfkg') it just does, then you will of cause get an error like ActiveRecord::StatementInvalid: PG::UndefinedTable: ERROR: relation "users" does not exist, if you try to do User.find(1) afterwards. But I guess that is okay, given that we save all the calls

[caironoleto]

For me, it's ok too but without a specific error can lead to a misunderstood about the problem.

Another way is to check the error to find a pattern like "relation (*) does not exist" and assume that error is because there is no schema. But is a weak solution.

[mikecmpbll]

i was looking in to how this relates to the TenantNotFound exception, and oddly it looks as though the pg adapter won't raise TenantNotFound because ActiveRecord::StatementInvalid isn't being caught :/. I assume the intention here was to raise TenantNotFound like the abstract adapter's connect_to_new does.

[jhubert]

Fwiw, this is what it does: