Separate MIDI generation into score vs. accompaniment#63
Draft
infojunkie wants to merge 3 commits intomainfrom
Draft
Separate MIDI generation into score vs. accompaniment#63infojunkie wants to merge 3 commits intomainfrom
infojunkie wants to merge 3 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #54 , we're moving away from trying to generate an MMA file that includes both the score music and accompaniment. Verovio does a great job at generating the score MIDI, and is actively maintained, so the idea is to offload the score generation to Verovio, and focus on accompaniment generation only with MMA.
We'll thus end up with 2 MIDI files that need to remain mutually consistent and get recombined. The biggest challenge for consistency is probably ensuring that the unrolling / expansion algorithms in Verovio and
unroll.xslfunction equivalently.There are several options for recombination:
MIDIIncdirective if it is robust enough