Add method to check if IP Address is inside Block range#59
Open
cherchezlafemme wants to merge 4 commits intoinfratographer:mainfrom
Open
Add method to check if IP Address is inside Block range#59cherchezlafemme wants to merge 4 commits intoinfratographer:mainfrom
cherchezlafemme wants to merge 4 commits intoinfratographer:mainfrom
Conversation
Signed-off-by: Anya Krupp <akrupp@equinix.com>
GraphQL Schema CheckCompared 0 schema changes against null operations ✅ Found no changes |
rizzza
reviewed
Oct 5, 2023
rizzza
reviewed
Oct 5, 2023
rizzza
reviewed
Oct 5, 2023
rizzza
reviewed
Oct 5, 2023
rizzza
reviewed
Oct 5, 2023
rizzza
reviewed
Oct 5, 2023
rizzza
reviewed
Oct 5, 2023
rizzza
reviewed
Oct 5, 2023
Contributor
|
The validation function should be added to the ip address schema, and unit tests created against the create/update resolver to catch issues in both the validator and the resolver input |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests describe the scenarios. Library used: https://pkg.go.dev/github.com/3th1nk/cidr@v0.2.0