Skip to content

add minus_path_weights to path weights#68

Open
dz24 wants to merge 5 commits intomainfrom
minusweights
Open

add minus_path_weights to path weights#68
dz24 wants to merge 5 commits intomainfrom
minusweights

Conversation

@dz24
Copy link
Copy Markdown
Collaborator

@dz24 dz24 commented Mar 10, 2026

Currently get_path_weights does not print the weights for the paths sampled in the [0-] ensemble.

We now do this, according to the simplified version under eq 19. in https://arxiv.org/abs/2602.05793

Note that the the minus paths are not sorted according to sampling.. maybe we should do that ..

@lukasbaldauf
Copy link
Copy Markdown
Contributor

lukasbaldauf commented Mar 10, 2026

Maybe we could save it to another file instead, e.g., by adding a -minus outfile option and only calculate these if that is given. Because we can't know whether it's a minus or a plus path from this, and most scripts that use the path_weights.txt file do not need minus paths.

@dz24
Copy link
Copy Markdown
Collaborator Author

dz24 commented Mar 10, 2026

What about just making it a bool option? and save it in the same file if -minus?

@lukasbaldauf
Copy link
Copy Markdown
Contributor

Then one would need to add another column as either ones or zeros to specify if the path is a minus path or not, which is maybe a bit redundant

@lukasbaldauf
Copy link
Copy Markdown
Contributor

lukasbaldauf commented Mar 10, 2026

Also, many of the scripts use the path_weights.txt file, so it might cause unexpected issues when they do not check if something is a minus or plus path (among other inf-init), which is why another text file might be preferred.

But I guess if the flag -minus is not given the files looks as previously, so nvm this comment.

@dz24
Copy link
Copy Markdown
Collaborator Author

dz24 commented Mar 10, 2026

Right, maybe you were more thinking about the following two averages
image

while I was thinking of
image

where I want the curly A average (which includes both 0- and i+ ensembles)

I guess either way works, but yeah I was thinking that just having a default -minus=False would not break stuff.

@dz24 dz24 requested a review from lukasbaldauf March 10, 2026 10:34
Copy link
Copy Markdown
Contributor

@lukasbaldauf lukasbaldauf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, yes I was thinking on that line. In that regard, we do not actually need to care about whether it's a minus or a plus path. And if its False by default all should be fine.
LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants