You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Maybe we could save it to another file instead, e.g., by adding a -minus outfile option and only calculate these if that is given. Because we can't know whether it's a minus or a plus path from this, and most scripts that use the path_weights.txt file do not need minus paths.
Also, many of the scripts use the path_weights.txt file, so it might cause unexpected issues when they do not check if something is a minus or plus path (among other inf-init), which is why another text file might be preferred.
But I guess if the flag -minus is not given the files looks as previously, so nvm this comment.
The reason will be displayed to describe this comment to others. Learn more.
Right, yes I was thinking on that line. In that regard, we do not actually need to care about whether it's a minus or a plus path. And if its False by default all should be fine.
LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
get_path_weightsdoes not print the weights for the paths sampled in the [0-] ensemble.We now do this, according to the simplified version under eq 19. in https://arxiv.org/abs/2602.05793
Note that the the minus paths are not sorted according to sampling.. maybe we should do that ..