Skip to content

Conversation

@cav-adhoc
Copy link
Contributor

In a transfer between a journal in main currency and one in secondary currency, the amount field in the journal entry for the main currency journal must be adjusted so it is recorded in the main currency, not in the secondary currency. This commit fixes that behavior.

Copilot AI review requested due to automatic review settings December 18, 2025 19:58
@roboadhoc
Copy link

Pull request status dashboard

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Este PR corrige el comportamiento de las transferencias internas entre journals con diferentes monedas, asegurando que los importes se registren correctamente en la moneda de la compañía para el journal con moneda principal.

Cambios clave:

  • Se añade el método _prepare_move_line_default_vals para ajustar los importes de las líneas de movimiento contable
  • Se implementa lógica para convertir amount_currency a la moneda de la compañía cuando el journal destino usa una moneda diferente

In a transfer between a journal in main currency and one in secondary currency,
the amount field in the journal entry for the main currency journal must be adjusted
so it is recorded in the main currency, not in the secondary currency. This commit fixes that behavior.
…warnings

Improve the user experience when managing internal transfer payments:

* Auto-synchronize paired payments: When updating amount or journals
  on one payment, automatically propagate changes to its paired payment
  to maintain consistency between both sides of the transfer

* State mismatch warning: Display an alert when paired payments are in
  different states, showing both current states and prompting users to
  synchronize them before completing changes

* Quick navigation: Add a "Go to Paired Payment" button directly in the
  warning message for easy access to the related payment

Technical improvements:
- Override write() method with recursion prevention via context flag
- Add computed HTML field for dynamic warning display
- Add action method for navigation between paired payments
- Update form view to display warnings before sheet content
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants