[REV] account_ux: rev _post to action_post #863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
There was a problem hiding this comment.
Pull request overview
Este PR revierte un commit previo (#857), cambiando el método sobreescrito de _post a action_post en el modelo account.move. El método action_post es la API pública estándar en Odoo para extender el comportamiento de publicación de movimientos contables, mientras que _post es un método interno. Este cambio asegura que el envío automático de emails a los partners (cuando el journal tiene configurado mail_template_id) se ejecute correctamente al publicar facturas.
Comment on lines
+23
to
28
| def action_post(self): | ||
| """After validate invoice will sent an email to the partner if the related journal has mail_template_id set""" | ||
| res = super()._post(soft=soft) | ||
| # Use action_post to ensure the mail is sent only when the move is posted | ||
| res = super().action_post() | ||
| self.action_send_invoice_mail() | ||
| return res |
There was a problem hiding this comment.
El método action_post sobreescrito ejecuta action_send_invoice_mail() después del post, pero no hay tests que verifiquen este comportamiento. Se recomienda agregar un test que valide:
- Que se envíe el correo cuando el journal tiene
mail_template_idconfigurado y el partner tiene email - Que se registre un mensaje en el chatter cuando falla el envío
- Que se registre un mensaje cuando el partner no tiene email
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts commit 0703bc4