[ADD] estate module #775
[ADD] estate module #775
Conversation
|
|
zaoral
left a comment
zaoral
left a comment
There was a problem hiding this comment.
Hi @hav-adhoc
Thank you for the PR!
Here are some comments so you can check them
Best Regards
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new estate module for managing real estate properties. The module provides a complete system for tracking properties, their types, tags, and offers.
- Adds core models for properties, property types, tags, and offers with relationships between them
- Implements XML views for list, form, and search interfaces across all models
- Sets up menu structure and security permissions for the estate management system
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| estate/manifest.py | Module manifest defining dependencies and data files |
| estate/init.py | Module initialization importing models |
| estate/models/init.py | Models package initialization |
| estate/models/estate_property.py | Main property model with fields and computed methods |
| estate/models/estate_property_type.py | Property type model for categorization |
| estate/models/estate_property_tag.py | Property tag model for labeling |
| estate/models/estate_property_offer.py | Property offer model with deadline calculations |
| estate/views/estate_property_views.xml | Property views and actions |
| estate/views/estate_property_type_views.xml | Property type views |
| estate/views/estate_property_tag_views.xml | Property tag views |
| estate/views/estate_property_offer_views.xml | Property offer views |
| estate/views/estate_property_menus.xml | Menu structure for the estate module |
| estate/security/ir.model.access.csv | Access control permissions |
| estate/.vscode/settings.json | VS Code configuration file |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| for record in self: | ||
| record.total_area = record.living_area + record.garden_area | ||
|
|
||
| @api.depends("best_price") |
There was a problem hiding this comment.
The @api.depends decorator references 'best_price' but the method computes 'best_price'. This creates a circular dependency. It should depend on 'offer_ids.price' instead.
| @api.depends("best_price") | |
| @api.depends("offer_ids.price") |
| garden_orientation = fields.Selection( | ||
| string="Orientation", selection=[("north", "North"), ("south", "South"), ("east", "East"), ("west", "West")] | ||
| ) | ||
| property_type_id = fields.Char() |
There was a problem hiding this comment.
The 'property_type_id' field should be a Many2one relationship to 'estate.property.type' model instead of a Char field to maintain referential integrity.
| property_type_id = fields.Char() | |
| property_type_id = fields.Many2one("estate.property.type", string="Property Type") |
3 participants
No description provided.