[FIX] sale_ux: Ensure correct account on downpayment lines #1267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rov-adhoc
force-pushed
the
18.0-h-94526-rov
branch
from
8ba17ff to
778f546
Compare
When creating a downpayment invoice for a sale order and then changing its company using the "Change Company" wizard and do not have a specific downpayment account in the product category, the account used in future invoices (to deduct the downpayment) could belong to the wrong company. This happened when the product's category lacked a specific downpayment account and the default income account was not shared across companies. This fix ensures that the account assigned to the downpayment deduction line in the final invoice belongs to the invoice's company. It fetches the proper account from the product's template, taking fiscal position into account.
rov-adhoc
force-pushed
the
18.0-h-94526-rov
branch
from
778f546 to
d1bde4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a downpayment invoice for a sale order and then changing its company using the "Change Company" wizard and do not have a specific downpayment account in the product category, the account used in future invoices (to deduct the downpayment) could belong to the wrong company.
This happened when the product's category lacked a specific downpayment account and the default income account was not shared across companies.
This fix ensures that the account assigned to the downpayment deduction line in the final invoice belongs to the invoice's company. It fetches the proper account from the product's template, taking fiscal position into account.