Skip to content

[ADD] portal_sale_distributor_mrp_subcontracting: new moudle #1492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
lav-adhoc wants to merge 1 commit into
base: 18.0
Choose a base branch
from
Open

[ADD] portal_sale_distributor_mrp_subcontracting: new moudle #1492

lav-adhoc wants to merge 1 commit into from

Conversation

@lav-adhoc
Copy link
Contributor

@lav-adhoc lav-adhoc commented Dec 3, 2025

No description provided.

Copilot AI review requested due to automatic review settings December 3, 2025 17:39
@roboadhoc
Copy link

roboadhoc commented Dec 3, 2025

Pull request status dashboard

Copilot AI reviewed Dec 3, 2025
View reviewed changes
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Este PR añade un nuevo módulo portal_sale_distributor_mrp_subcontracting que extiende la funcionalidad del portal de distribuidores para trabajar con subcontratación MRP. El módulo proporciona reglas de acceso a modelos de almacén, unidades de medida y ubicaciones de stock para usuarios distribuidores del portal.

Cambios principales

  • Nuevo módulo auto-instalable que integra portal_sale_distributor con mrp_subcontracting
  • Tres reglas de seguridad para modelos: almacenes, unidades de medida y ubicaciones de stock
  • Documentación y archivos de traducción básicos

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 13 comments.

Show a summary per file
File Description
__manifest__.py Define el nuevo módulo con dependencias a mrp_subcontracting y portal_sale_distributor
security/portal_sale_distributor_security.xml Añade tres reglas de acceso para modelos relacionados con subcontratación
i18n/es.po Archivo de traducción al español (vacío de contenido traducible)
__init__.py Archivo de inicialización estándar del módulo
README.rst Documentación del módulo con instrucciones de instalación y uso

portal_sale_distributor_mrp_subcontracting/security/portal_sale_distributor_security.xml Outdated
Comment on lines 5 to 38
<record id="portal_sale_order_user_rule" model="ir.rule">
<field name="name">Portal Distributor Warehouses Subcontractor</field>
<field name="model_id" ref="stock.model_stock_warehouse"/>
<field name="domain_force">[(1 ,'=', 1)]</field>
<field name="groups" eval="[(4, ref('group_portal_backend_distributor'))]"/>
<field eval="1" name="perm_unlink"/>
<field eval="0" name="perm_write"/>
<field eval="0" name="perm_read"/>
<field eval="0" name="perm_create"/>
</record>

<!-- Sale Portal Distributor CRUD for UoM Subcontractor with MRP Subcontrating -->
<record id="portal_sale_order_user_rule" model="ir.rule">
<field name="name">Portal Distributor UoM Subcontractor</field>
<field name="model_id" ref="uom.model_uom_uom"/>
<field name="domain_force">[(1 ,'=', 1)]</field>
<field name="groups" eval="[(4, ref('group_portal_backend_distributor'))]"/>
<field eval="1" name="perm_unlink"/>
<field eval="0" name="perm_write"/>
<field eval="0" name="perm_read"/>
<field eval="0" name="perm_create"/>
</record>

<!-- Sale Portal Distributor CRUD for UoM Subcontractor with MRP Subcontrating -->
<record id="portal_sale_order_user_rule" model="ir.rule">
<field name="name">Portal Distributor UoM Subcontractor</field>
<field name="model_id" ref="stock.model_stock_location"/>
<field name="domain_force">[(1 ,'=', 1)]</field>
<field name="groups" eval="[(4, ref('group_portal_backend_distributor'))]"/>
<field eval="1" name="perm_unlink"/>
<field eval="0" name="perm_write"/>
<field eval="0" name="perm_read"/>
<field eval="0" name="perm_create"/>
</record>
Copy link

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Los tres registros de reglas de seguridad tienen el mismo ID XML portal_sale_order_user_rule, lo que causará un conflicto. Cada registro debe tener un ID único. Sugerencia:

  • Primera regla: portal_warehouse_subcontractor_rule
  • Segunda regla: portal_uom_subcontractor_rule
  • Tercera regla: portal_stock_location_subcontractor_rule

Copilot uses AI. Check for mistakes.
portal_sale_distributor_mrp_subcontracting/security/distributor_mrp_subcontratin_security.xml
Comment on lines +22 to +25
<field eval="1" name="perm_unlink"/>
<field eval="0" name="perm_write"/>
<field eval="0" name="perm_read"/>
<field eval="0" name="perm_create"/>
Copy link

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Los permisos configurados para esta regla son contradictorios: todos los permisos están en 0 excepto perm_unlink que está en 1. Esto significa que los usuarios solo pueden eliminar registros pero no pueden leerlos, crearlos ni modificarlos. Normalmente, si se necesita acceso de lectura para permitir operaciones relacionadas con subcontratación, debería ser perm_read=1 y perm_unlink=0. Verificar cuál es el comportamiento deseado.

Copilot uses AI. Check for mistakes.
portal_sale_distributor_mrp_subcontracting/security/portal_sale_distributor_security.xml Outdated
Comment on lines 28 to 30
<!-- Sale Portal Distributor CRUD for UoM Subcontractor with MRP Subcontrating -->
<record id="portal_sale_order_user_rule" model="ir.rule">
<field name="name">Portal Distributor UoM Subcontractor</field>
Copy link

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

El comentario indica "UoM Subcontractor" pero el modelo referenciado es stock.model_stock_location (ubicaciones de stock), no UoM. El comentario debería ser algo como "Portal Distributor Stock Location Subcontractor" para que coincida con el modelo real.

Suggested change
<!-- Sale Portal Distributor CRUD for UoM Subcontractor with MRP Subcontrating -->
<record id="portal_sale_order_user_rule" model="ir.rule">
<field name="name">Portal Distributor UoM Subcontractor</field>
<!-- Sale Portal Distributor CRUD for Stock Location Subcontractor with MRP Subcontracting -->
<record id="portal_sale_order_user_rule" model="ir.rule">
<field name="name">Portal Distributor Stock Location Subcontractor</field>

Copilot uses AI. Check for mistakes.
portal_sale_distributor_mrp_subcontracting/security/distributor_mrp_subcontratin_security.xml
Comment on lines +34 to +37
<field eval="1" name="perm_unlink"/>
<field eval="0" name="perm_write"/>
<field eval="0" name="perm_read"/>
<field eval="0" name="perm_create"/>
Copy link

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Los permisos configurados para esta regla son contradictorios: todos los permisos están en 0 excepto perm_unlink que está en 1. Esto significa que los usuarios solo pueden eliminar registros pero no pueden leerlos, crearlos ni modificarlos. Normalmente, si se necesita acceso de lectura para permitir operaciones relacionadas con subcontratación, debería ser perm_read=1 y perm_unlink=0. Verificar cuál es el comportamiento deseado.

Copilot uses AI. Check for mistakes.
portal_sale_distributor_mrp_subcontracting/security/portal_sale_distributor_security.xml Outdated
<field eval="0" name="perm_create"/>
</record>

<!-- Sale Portal Distributor CRUD for UoM Subcontractor with MRP Subcontrating -->
Copy link

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error ortográfico en el comentario: "Subcontrating" debería ser "Subcontracting".

Copilot uses AI. Check for mistakes.
portal_sale_distributor_mrp_subcontracting/security/distributor_mrp_subcontratin_security.xml
<?xml version="1.0" encoding="utf-8"?>
<odoo noupdate="1">

<!-- Sale Portal Distributor CRUD for Stock Warehouse with MRP Subcontrating -->
Copy link

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error ortográfico en el título del PR: "moudle" debería ser "module".

Copilot uses AI. Check for mistakes.
portal_sale_distributor_mrp_subcontracting/security/distributor_mrp_subcontratin_security.xml
<field name="name">Portal Distributor Warehouses Subcontractor</field>
<field name="model_id" ref="stock.model_stock_warehouse"/>
<field name="domain_force">[(1 ,'=', 1)]</field>
<field name="groups" eval="[(4, ref('group_portal_backend_distributor'))]"/>
Copy link

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La referencia al grupo group_portal_backend_distributor no incluye el módulo de origen. Debería ser ref('portal_sale_distributor.group_portal_backend_distributor') para referenciar correctamente el grupo definido en el módulo de dependencia.

Copilot uses AI. Check for mistakes.
portal_sale_distributor_mrp_subcontracting/security/distributor_mrp_subcontratin_security.xml
<field name="name">Portal Distributor UoM Subcontractor</field>
<field name="model_id" ref="stock.model_stock_location"/>
<field name="domain_force">[(1 ,'=', 1)]</field>
<field name="groups" eval="[(4, ref('group_portal_backend_distributor'))]"/>
Copy link

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La referencia al grupo group_portal_backend_distributor no incluye el módulo de origen. Debería ser ref('portal_sale_distributor.group_portal_backend_distributor') para referenciar correctamente el grupo definido en el módulo de dependencia.

Copilot uses AI. Check for mistakes.
portal_sale_distributor_mrp_subcontracting/README.rst Outdated
Portal Distributor Sale with MRP
================================

This module integrate portal sale distributor using MRP.
Copy link

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error ortográfico: "integrate" debería ser "integrates" para concordar con el sujeto singular "module".

Suggested change
This module integrate portal sale distributor using MRP.
This module integrates portal sale distributor using MRP.

Copilot uses AI. Check for mistakes.
portal_sale_distributor_mrp_subcontracting/README.rst

This module integrate portal sale distributor using MRP.

#. Add a model access rule in order to able portal distributor users to add products in sale orders.
Copy link

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error ortográfico: "able" debería ser "enable" (habilitar) en este contexto. "Able" es un adjetivo, mientras que se necesita un verbo.

Suggested change
#. Add a model access rule in order to able portal distributor users to add products in sale orders.
#. Add a model access rule in order to enable portal distributor users to add products in sale orders.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lav-adhoc @roboadhoc