-
Notifications
You must be signed in to change notification settings - Fork 1
Add pot action 2 #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vib-adhoc
wants to merge
7
commits into
18.0
Choose a base branch
from
add-pot-action-2
base: 18.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add pot action 2 #69
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
bc04535
Delete langs
vib-adhoc 7886d59
Translated using Weblate (Spanish)
vib-adhoc 4ce6ea4
Translated using Weblate (Spanish)
vib-adhoc d01b45c
Add workflow to update .pot files on push to specific branches
vib-adhoc 8226698
Merge pull request #68 from ingadhoc/add-pot-action
vib-adhoc 1846175
Test
vib-adhoc 76d46fe
Merge branch '19.0' into add-pot-action-2
vib-adhoc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # ⚠️ DO NOT EDIT THIS FILE, IT IS GENERATED BY COPIER ⚠️ | ||
| # Changes here will be lost on a future update. | ||
| # See: https://github.com/ingadhoc/addons-repo-template | ||
|
|
||
| name: Update .pot files | ||
|
|
||
| on: | ||
| push: | ||
| branches: "*.0-*" | ||
|
|
||
| jobs: | ||
| update-pot: | ||
| runs-on: ubuntu-22.04 | ||
| container: ghcr.io/oca/oca-ci/py3.10-odoo17.0:latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| persist-credentials: false | ||
|
|
||
| - name: Update .pot files | ||
| run: | | ||
| oca_export_and_push_pot \ | ||
| https://x-access-token:${{ secrets.GIT_PUSH_TOKEN }}@github.com/${{ github.repository }} | ||
| if: ${{ github.repository_owner == 'ingadhoc' }} | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| ############################################################################## | ||
| # For copyright and license notices, see __manifest__.py file in module root | ||
| # directory | ||
| ############################################################################## | ||
| from . import res_partner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| ############################################################################## | ||
| # For copyright and license notices, see __manifest__.py file in module root | ||
| # directory | ||
| ############################################################################## | ||
|
|
||
| from odoo import fields, models | ||
|
|
||
|
|
||
| class partner(models.Model): | ||
| _inherit = "res.partner" | ||
| abc_sales_amount = fields.Char("ABC Sales amount") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,16 @@ | ||||||||||||||||||||||
| <?xml version="1.0" encoding="utf-8"?> | ||||||||||||||||||||||
| <odoo> | ||||||||||||||||||||||
| <!-- INHERITED FORM --> | ||||||||||||||||||||||
| <record id="view_partner_user_form" model="ir.ui.view"> | ||||||||||||||||||||||
| <field name="name">partner.user.form</field> | ||||||||||||||||||||||
| <field name="model">res.partner</field> | ||||||||||||||||||||||
| <field name="inherit_id" ref="base.view_partner_form"/> | ||||||||||||||||||||||
| <field name="arch" type="xml"> | ||||||||||||||||||||||
| <page name="sales_purchases"> | ||||||||||||||||||||||
| <group name="clasificacion_abc" string="Clasificacion ABC"> | ||||||||||||||||||||||
|
||||||||||||||||||||||
| <group name="clasificacion_abc" string="Clasificacion ABC"> | |
| <group name="clasificacion_abc" string="Clasificación ABC"> |
Comment on lines
+9
to
+13
Copilot
AI
Nov 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The XPath selector references page name="sales_purchases" without specifying a position attribute. According to Odoo XML inheritance best practices, you should explicitly specify the position attribute (e.g., position="inside") to make the inheritance behavior clear and predictable.
Suggested change
| <page name="sales_purchases"> | |
| <group name="clasificacion_abc" string="Clasificacion ABC"> | |
| <field name="abc_sales_amount"/> | |
| </group> | |
| </page> | |
| <xpath expr="//page[@name='sales_purchases']" position="inside"> | |
| <group name="clasificacion_abc" string="Clasificacion ABC"> | |
| <field name="abc_sales_amount"/> | |
| </group> | |
| </xpath> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version mismatch: The workflow uses
py3.10-odoo17.0:latestcontainer, but the module manifest indicates version 18.0 (partner_sales_abc/__manifest__.pyline 22). This mismatch may cause compatibility issues during POT file generation. Consider updating to usepy3.10-odoo18.0:latestor the appropriate Odoo 18 container.