:base-path option to allow deployment on non-root paths#110
Open
grmble wants to merge 1 commit intoingesolvoll:masterfrom
Open
:base-path option to allow deployment on non-root paths#110grmble wants to merge 1 commit intoingesolvoll:masterfrom
grmble wants to merge 1 commit intoingesolvoll:masterfrom
Conversation
works with and without hashed urls
Owner
|
@grmble Thanks a lot for this fix! Since I'm not actively working on kee-frame these days, I'm going to ask you to help me verify this. I'm guessing you are using a git dependency or a fork to use these changes yourself? Would you say the change is working in a stable way, and it's safe to include in the general library? If yes, I'll merge this and see if I can remember the release procedure 😄 |
Owner
|
Also, sorry for leaving you hanging on this, @grmble . Hope you found a way to use this without a release. |
Author
|
@ingesolvoll I am simply using my fork in deps.edn, lack of release is not a problem for me. I do think the change works in a stable way, but I am only using it in a hobby project with an audience of 1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would like to be able to deploy kee-frame applications on github project pages which typically look like yourname.github.io/your-project. This does not work at all unless you disable route hashing. But then your application will only work as long as you start it by going to the root route. If you reload the page while on a route not backed by an actual page you get an error.
Another option would be to have reitit do all the work. There is a
:pathoption and a:use-fragmentoption, but I did not actually try this. https://cljdoc.org/d/metosin/reitit/0.5.18/doc/frontend/browser-integrationfixes #109