Skip to content

Bug fix and reword for scrolling feature#113

Open
Akeboshiwind wants to merge 4 commits intoingesolvoll:masterfrom
juxt-forks:fix-scroll
Open

Bug fix and reword for scrolling feature#113
Akeboshiwind wants to merge 4 commits intoingesolvoll:masterfrom
juxt-forks:fix-scroll

Conversation

@Akeboshiwind
Copy link
Copy Markdown

Does two things:

  • Adjusts the wording in the README to better reflect current code
  • Fix a bug where pages don't scroll if there's no ajax request made

It does this by changing :route-counter to be just a pure number and not keep track of the route.
Now:

  • ::poll checks against the :kee-frame/route which is updated before ::poll is called
  • Ajax interceptors are only setup once (a small efficiency gain)
  • monitor-requests! is part of the cond-> in ::route-changed which seems a bit cleaner

I've tested that this works against this repo I created: https://github.com/ake-temp/kee-frame-scroll-repro

@egg-juxt egg-juxt deleted the fix-scroll branch March 6, 2024 16:30
@egg-juxt egg-juxt restored the fix-scroll branch March 6, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants