Test improvement #663
Open
Test improvement #663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-subrepo requires being on a branch due to how some of the internals operate. Prevent CI issues when testing PRs by ensuring we are ona branch.
Docker and the user are not the same user. Tell the system that it is ok that the .git directory isn't the same user
Git changed the error message about being in a worktree, handle both versions.
Both bash and git versions matter for subrepo, test a matrix of both instead of only the newest git version and all bash versions. Had to remove git 2.7 because it can't be built on modern Ubuntu.
Before git 2.28 the default branch wasn't supported, and before 2.25 the --default option wasn't available with git config.
When adding tests for all version I discovered that git before 2.23 caused subrepo issues due to how --is-ancestor worked. I tried to find a way to support both versions, but was not successful so I decided to drop support for the older versions.
Bash+ library requires Bash 4.0 or higher
Stop using the one build for bash+ and use one specifically designed for git-subrepo
admorgan
force-pushed
the
test_improvement
branch
from
1d9b4fa to
ae34e84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI has been failing some tests due to not having a branch since I came on the project. These fix that issue and a number of other issues I discovered while updating the infrastructure to test more combinations of bash and git with subrepo.