-
Notifications
You must be signed in to change notification settings - Fork 0
fix: glibc runtime errors #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
6d5c872
to
cb3bc3c
Compare
Dockerfile
Outdated
FROM --platform=$TARGETPLATFORM lukemathwalker/cargo-chef:latest-rust-latest as chef | ||
### Use a Debian bookworm-based Rust image so GLIBC matches the final runtime (bookworm ships glibc 2.36) | ||
### cargo-chef is then installed into this pinned base | ||
FROM --platform=$TARGETPLATFORM rust:1.90-bookworm AS chef |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this locks our rust version used in the dockerfile and this is something i'd preferably not want to track. Can't we use a "latest stable" image?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I concur, specifically I think we'd want the tag slim
as that appears to be the equivalent of latest slim
and I can't think of a good reason to pin to the version of debian at all. I think slim has everything we need (with the installs)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What changed that impacted glibc btw, just curious
Root cause was that 5 days ago, a new release of Re: Image version - Version specification can loosen to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perfect
Merge activity
|
fix: glibc runtime errors
This PR updates the docker stage 0 to use a known version of
bookworm
in for the nextcargo-chef
build step instead of thelukemathwalker/cargo-check
image that it previously used in order to maintainglibc
compatibility with thedebian:bookwork-slim
image used in stage 3.Testing
Built a container with github actions and ran it in DevNet - tl;dr it landed blocks and the runtime error was gone.
Closes ENG-1424