Skip to content

feat: Add missing template name and filters to speaker block model#10

Merged
tusharmane-tm merged 1 commit intomainfrom
qa
Feb 6, 2026
Merged

feat: Add missing template name and filters to speaker block model#10
tusharmane-tm merged 1 commit intomainfrom
qa

Conversation

@tusharmane-tm
Copy link
Contributor

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #

Test URLs:

@aem-code-sync
Copy link

aem-code-sync bot commented Feb 6, 2026

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@gemini-code-assist
Copy link

Summary of Changes

Hello @tusharmane-tm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the _speaker.json model by incorporating a specific template name and an empty filters array. These changes aim to improve the clarity and extensibility of the speaker block configuration, allowing for better identification and future implementation of content filtering mechanisms.

Highlights

  • Template Name Addition: The name property with the value Speaker has been added to the template configuration within the _speaker.json model, ensuring explicit identification of the speaker template.
  • Filters Array Introduction: An empty filters array has been introduced at the root level of the _speaker.json model, providing a placeholder for future filtering capabilities.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • ue/models/blocks/_speaker.json
    • Added the "name": "Speaker" property within the template object under the page configuration.
    • Introduced an empty "filters": [] array at the root level of the JSON structure.
Activity
  • No specific activity (comments, reviews, etc.) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the missing name and filters properties to the speaker block model. These changes align the speaker block with the expected component model structure, adding a display name for the template and ensuring the filters property is present. The changes are correct and improve the consistency of the component definitions.

@tusharmane-tm tusharmane-tm merged commit 6d4ddbc into main Feb 6, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant