Skip to content

feat: Add speaker element template with dynamic properties#12

Merged
tusharmane-tm merged 1 commit intomainfrom
qa
Feb 6, 2026
Merged

feat: Add speaker element template with dynamic properties#12
tusharmane-tm merged 1 commit intomainfrom
qa

Conversation

@tusharmane-tm
Copy link
Contributor

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #

Test URLs:

@aem-code-sync
Copy link

aem-code-sync bot commented Feb 6, 2026

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@gemini-code-assist
Copy link

Summary of Changes

Hello @tusharmane-tm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the content rendering capabilities by introducing a dedicated HTML template for speaker profiles. The new template is designed to be highly dynamic, allowing for the seamless integration of speaker-specific data through properties, which will improve the reusability and maintainability of speaker-related content across the platform.

Highlights

  • New Speaker Element Template: Introduces a new HTML template file, cf-template/speaker.html, designed to dynamically render speaker information.
  • Dynamic Property Integration: The new template utilizes dynamic properties for various speaker details, including ID, image source, title, job title, and company name, ensuring flexible content presentation.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • cf-template/speaker.html
    • Added a new HTML template file named speaker.html.
    • The template defines a div element with the class speaker-elmeent and a dynamically assigned id.
    • It includes a picture element containing an img tag, where the src, alt, and title attributes are populated using dynamic properties.
    • Dynamic properties are also used to display the speaker's title, jobTitle, and companyName within h1 and p tags.
Activity
  • No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@tusharmane-tm tusharmane-tm merged commit be15e1e into main Feb 6, 2026
1 of 2 checks passed
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new HTML template for a speaker element. The review identified a few areas for improvement in the new cf-template/speaker.html file. There's a typo in a CSS class name that should be corrected. The template also uses an <h1> tag for the speaker's name, which is not ideal for document structure and accessibility; a lower-level heading is recommended. Finally, the markup for the image can be simplified by removing a redundant <picture> element and a duplicative title attribute on the <img> tag.

@@ -0,0 +1,11 @@

<div class="speaker-elmeent" id="{{properties.elements.id.value}}">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

There is a typo in the class name speaker-elmeent. This should likely be speaker-element to be consistent and to ensure any associated styles are applied correctly.

Suggested change
<div class="speaker-elmeent" id="{{properties.elements.id.value}}">
<div class="speaker-element" id="{{properties.elements.id.value}}">

Comment on lines +4 to +6
<picture>
<img src="{{properties.elements.image_ext.value}}" alt="{{properties.elements.title.value}}" title="{{properties.elements.title.value}}">
</picture>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The <picture> element is redundant here as it only contains an <img> tag without any <source> elements. It can be removed for simpler markup. Additionally, the title attribute on the <img> tag duplicates the alt attribute's content, which is not recommended as it can cause issues for screen reader users. It's best to remove the title attribute in this case.

        <img src="{{properties.elements.image_ext.value}}" alt="{{properties.elements.title.value}}">

<picture>
<img src="{{properties.elements.image_ext.value}}" alt="{{properties.elements.title.value}}" title="{{properties.elements.title.value}}">
</picture>
<h1>{{properties.elements.title.value}}</h1>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Using an <h1> for the speaker's name is not recommended as it can harm SEO and accessibility. Typically, a page should have only one <h1> for the main title. For components like this, it's better to use a lower-level heading (e.g., <h2>, <h3>) or a styled <p> tag to maintain a proper document outline.

        <h2>{{properties.elements.title.value}}</h2>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant