Skip to content

QA to Main#7

Merged
tusharmane-tm merged 2 commits intomainfrom
qa
Feb 3, 2026
Merged

QA to Main#7
tusharmane-tm merged 2 commits intomainfrom
qa

Conversation

@tusharmane-tm
Copy link
Contributor

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #

Test URLs:

@aem-code-sync
Copy link

aem-code-sync bot commented Feb 3, 2026

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@gemini-code-assist
Copy link

Summary of Changes

Hello @tusharmane-tm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the project's compatibility with the AEM Universal Editor by introducing new client-side logic for dynamic content updates and rich text handling. These changes aim to streamline the authoring experience within AEM, allowing for more fluid and responsive content editing. Additionally, the local development environment has been made more flexible by providing dedicated scripts for different AEM instances.

Highlights

  • AEM Universal Editor Integration: Introduced new JavaScript files (editor-support-rte.js and editor-support.js) to provide comprehensive support for the Adobe Experience Manager (AEM) Universal Editor, enabling real-time content updates and enhanced authoring capabilities.
  • Rich Text Decoration Logic: Added a decorateRichtext function that intelligently groups consecutive rich text elements into single wrappers, applying AEM Universal Editor attributes for improved editing and content structure.
  • Dynamic Content Redecoration: Implemented an applyChanges function that listens for AEM Universal Editor events (e.g., content-patch, content-update) and dynamically redecorates affected main content, blocks, and sections, ensuring the UI reflects the latest changes.
  • Development Script Refactoring: Modified package.json to replace a single dev script with three distinct scripts (dev:da, dev:gdrive, dev:ue), each configured to launch a local development server against a specific AEM instance.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • package.json
    • Replaced the single dev script with dev:da, dev:gdrive, and dev:ue to support development against different AEM instances.
    • Each new script now points to a specific AEM instance URL for targeted local testing.
  • scripts/editor-support-rte.js
    • Added a new file containing the decorateRichtext function.
    • This function identifies and groups HTML elements with data-richtext-prop attributes into a single div wrapper, applying data-aue-* attributes for AEM Universal Editor integration.
    • Includes logic to remove instrumentation attributes and handles potential 'orphan' rich text elements with console warnings.
  • scripts/editor-support.js
    • Added a new file to manage AEM Universal Editor interactions.
    • Introduced an applyChanges asynchronous function that redecorates main content, blocks, and sections based on aue: events (e.g., content-patch, content-update, content-add, content-move, content-remove, content-copy).
    • Incorporates DOMPurify for sanitizing incoming content updates from the editor.
    • Attaches event listeners to the main element for various AEM Universal Editor events.
    • Initializes decorateRichtext and sets up a MutationObserver to dynamically apply rich text decoration when data-richtext-prop attributes change in the DOM.
Activity
  • The pull request title 'QA to Main' suggests a merge from a quality assurance branch to the main development line.
  • The description body is a standard template, indicating no specific human activity or comments have been added yet beyond the initial PR creation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for the Adobe Universal Editor by adding new scripts to handle live content updates and rich text editing decoration. It also updates the npm scripts for different development environments. The review identifies a critical bug that could cause a runtime error when handling editor updates, and another high-severity bug related to incorrect attribute selection which would prevent a feature from working correctly. Suggestions for fixes are provided for both issues.

@tusharmane-tm tusharmane-tm merged commit 94dde64 into main Feb 3, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant