-
Notifications
You must be signed in to change notification settings - Fork 88
test: add test coverage for getDIDDocument endopoint and improve JavaDoc #291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
0Drishtant0
wants to merge
25
commits into
inji:master
Choose a base branch
from
0Drishtant0:enhance/did-document-test-coverage
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
test: add test coverage for getDIDDocument endopoint and improve JavaDoc #291
0Drishtant0
wants to merge
25
commits into
inji:master
from
0Drishtant0:enhance/did-document-test-coverage
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [INJICERT-895] Bug fixes relateed to spec compliance Changes: fix for did:jwk resolution made iss as optional, remove exp field Signed-off-by: Hitesh Jain <jainhitesh9998@gmail.com> * [INJICERT-895] Added exp claim as optional Signed-off-by: Hitesh Jain <jainhitesh9998@gmail.com> --------- Signed-off-by: Hitesh Jain <jainhitesh9998@gmail.com> Signed-off-by: Vishwa <visu.vs1@gmail.com>
fixed issue related to concurrency and static variable Signed-off-by: Hitesh Jain <jainhitesh9998@gmail.com>
[INJICERT-895]
Signed-off-by: Hitesh Jain <jainhitesh9998@gmail.com>
Signed-off-by: Hitesh Jain <jainhitesh9998@gmail.com>
Signed-off-by: Hitesh Jain <jainhitesh9998@gmail.com>
[INJICERT-895]
* [DSD-7419] updated base image for certify with plugins Signed-off-by: Hitesh Jain <jainhitesh9998@gmail.com> * [DSD-7420] (inji#244) Signed-off-by: Hitesh Jain <jainhitesh9998@gmail.com> (cherry picked from commit 9b16e0b) * [INJICERT-936] Signed-off-by: Hitesh Jain <jainhitesh9998@gmail.com> * [INJICERT-936] addressed review comments Signed-off-by: Hitesh C <jainhitesh9998@gmail.com> * [INJICERT-936] updated helm chart with redirect of did.json Signed-off-by: Hitesh C <jainhitesh9998@gmail.com> * [INJICERT-936] removed R1 algorithm from csv file Signed-off-by: Hitesh C <jainhitesh9998@gmail.com> * [INJICERT-936] updated well-known Signed-off-by: Hitesh C <jainhitesh9998@gmail.com> * Moved the changes to RELEASES.md file Signed-off-by: Hitesh C <jainhitesh9998@gmail.com> * [INJICERT-936] Removed ec k1 2016 - Not part of release Signed-off-by: Hitesh C <jainhitesh9998@gmail.com> --------- Signed-off-by: Hitesh Jain <jainhitesh9998@gmail.com> Signed-off-by: Hitesh C <jainhitesh9998@gmail.com>
* [MOSIP-35637] added sqaush layers Signed-off-by: Rakshith B <79500257+Rakshithb1@users.noreply.github.com> * MOSIP-39719 Signed-off-by: Nandhukumar <nandhukumare@gmail.com> * MOSIP-39719 Signed-off-by: Nandhukumar <nandhukumare@gmail.com> * MOSIP-39719 Signed-off-by: Nandhukumar <nandhukumare@gmail.com> * MOSIP-39719 - Added a log level for the commons classes * MOSIP-39719 Signed-off-by: Nandhukumar <nandhukumare@gmail.com> * MOSIP-39719 Signed-off-by: Nandhukumar <nandhukumare@gmail.com> * MOSIP-39719 Signed-off-by: Nandhukumar <nandhukumare@gmail.com> --------- Signed-off-by: Nandhukumar <nandhukumare@gmail.com> * MOSIP-38542 Signed-off-by: Nandhukumar <nandhukumare@gmail.com> * [MOSIP-39957] Updated chart version and repo name for certify db (inji#239) Signed-off-by: Abhi <abhishek.shankarcs@gmail.com> * Merge pull request inji#236 from Infosys/INJICERT-895 (inji#241) [INJICERT-895] Signed-off-by: Hitesh Jain <jainhitesh9998@gmail.com> Co-authored-by: Vishwa <visu.vs1@gmail.com> * Mosip 39047 - Commons cleanup (inji#250) * MOSIP-39047 Signed-off-by: Nandhukumar <nandhukumare@gmail.com> * MOSIP-39047 Signed-off-by: Nandhukumar <nandhukumare@gmail.com> * MOSIP-39047 Signed-off-by: Nandhukumar <nandhukumare@gmail.com> * MOSIP-39047 Signed-off-by: Nandhukumar <nandhukumare@gmail.com> * MOSIP-39047 Signed-off-by: Nandhukumar <nandhukumare@gmail.com> --------- Signed-off-by: Nandhukumar <nandhukumare@gmail.com> * MOSIP-40467 Signed-off-by: Nandhukumar <nandhukumare@gmail.com> * MOSIP-40467 Signed-off-by: Nandhukumar <nandhukumare@gmail.com> * MOSIP-40467 - Generate unique identity data for sunbird policy to avoid duplicate conflict (inji#251) * MOSIP-40467 Signed-off-by: Nandhukumar <nandhukumare@gmail.com> * MOSIP-40467 Signed-off-by: Nandhukumar <nandhukumare@gmail.com> --------- Signed-off-by: Nandhukumar <nandhukumare@gmail.com> * MOSIP-39047 Signed-off-by: Nandhukumar <nandhukumare@gmail.com> * MOSIP-39047 Signed-off-by: Nandhukumar <nandhukumare@gmail.com> * MOSIP-39047 - Commons cleanup (inji#253) * MOSIP-40467 Signed-off-by: Nandhukumar <nandhukumare@gmail.com> * MOSIP-40467 Signed-off-by: Nandhukumar <nandhukumare@gmail.com> * MOSIP-39047 Signed-off-by: Nandhukumar <nandhukumare@gmail.com> * MOSIP-39047 Signed-off-by: Nandhukumar <nandhukumare@gmail.com> --------- Signed-off-by: Nandhukumar <nandhukumare@gmail.com> * MOSIP-40516 Signed-off-by: Nandhukumar <nandhukumare@gmail.com> * MOSIP-40516 - Fix the automation failures while running only the smoke test (inji#254) * MOSIP-40467 Signed-off-by: Nandhukumar <nandhukumare@gmail.com> * MOSIP-40467 Signed-off-by: Nandhukumar <nandhukumare@gmail.com> * MOSIP-39047 Signed-off-by: Nandhukumar <nandhukumare@gmail.com> * MOSIP-39047 Signed-off-by: Nandhukumar <nandhukumare@gmail.com> * MOSIP-40516 Signed-off-by: Nandhukumar <nandhukumare@gmail.com> --------- Signed-off-by: Nandhukumar <nandhukumare@gmail.com> * INJICERT-944 Signed-off-by: Nandhukumar <nandhukumare@gmail.com> * MOSIP-40791 Signed-off-by: Nandhukumar <nandhukumare@gmail.com> * MOSIP-40791 Signed-off-by: Nandhukumar <nandhukumare@gmail.com> * MOSIP-40791 Signed-off-by: Nandhukumar <nandhukumare@gmail.com> * MOSIP-40791 Signed-off-by: Nandhukumar <nandhukumare@gmail.com> --------- Signed-off-by: Rakshith B <79500257+Rakshithb1@users.noreply.github.com> Signed-off-by: Nandhukumar <nandhukumare@gmail.com> Signed-off-by: Abhi <abhishek.shankarcs@gmail.com> Signed-off-by: Hitesh Jain <jainhitesh9998@gmail.com> Co-authored-by: Rakshith B <79500257+Rakshithb1@users.noreply.github.com> Co-authored-by: Chandra Keshav Mishra <chandrakeshavmishra@gmail.com> Co-authored-by: Abhishek S <127825992+abhishek8shankar@users.noreply.github.com> Co-authored-by: Hitesh Jain <jainhitesh9998@gmail.com> Co-authored-by: Vishwa <visu.vs1@gmail.com>
Signed-off-by: Nandhukumar <nandhukumare@gmail.com>
…#264) Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>
… readme (inji#265) Signed-off-by: Piyush7034 <piyushshukla2100@gmail.com>
Signed-off-by: Chandra Keshav Mishra <chandrakeshavmishra@gmail.com>
[DSD-7795] added issue templates for c4gt
Signed-off-by: Chandra Keshav Mishra <chandrakeshavmishra@gmail.com>
Signed-off-by: Nandhukumar <nandhukumare@gmail.com>
MOSIP-40791 - Synced latest changes from develop
…ersion is older than 1.5.1 (inji#289)
Author
* [INJICERT-1001] added additional docs for mosipid usecase compatibility Signed-off-by: Hitesh Jain <jainhitesh9998@gmail.com> * updated readme Signed-off-by: Hitesh Jain <jainhitesh9998@gmail.com> * [INJICERT-1001] updated readme Signed-off-by: Hitesh Jain <jainhitesh9998@gmail.com> * updated readme Signed-off-by: Hitesh Jain <jainhitesh9998@gmail.com> * updated readme Signed-off-by: Hitesh Jain <jainhitesh9998@gmail.com> * updated readme Signed-off-by: Hitesh Jain <jainhitesh9998@gmail.com> * updated readme Signed-off-by: Hitesh Jain <jainhitesh9998@gmail.com> * changed readme Signed-off-by: Hitesh Jain <jainhitesh9998@gmail.com> * Update Custom-Plugin-K8s.md Signed-off-by: Hitesh Jain <jainhitesh9998@gmail.com> --------- Signed-off-by: Hitesh Jain <jainhitesh9998@gmail.com> Signed-off-by: Vishwa <visu.vs1@gmail.com>
inji#316) * [MOSIP-41354] Added manual workflow and updated push-trigger workflow for to support the circular dependency from inji-certify-plugins (inji#315) * [MOSIP-41354] Added manual workflow and updated push-trigger workflow for to support the circular dependency from inji-certify-plugins Signed-off-by: techno-467 <prafulrakhade02@gmail.com> * [MOSIP-41354] Added manual workflow and updated push-trigger workflow for to support the circular dependency from inji-certify-plugins Signed-off-by: techno-467 <prafulrakhade02@gmail.com> * [MOSIP-41354] Added manual workflow and updated push-trigger workflow for to support the circular dependency from inji-certify-plugins Signed-off-by: techno-467 <prafulrakhade02@gmail.com> * [MOSIP-41354] Added manual workflow and updated push-trigger workflow for to support the circular dependency from inji-certify-plugins Signed-off-by: techno-467 <prafulrakhade02@gmail.com> * [MOSIP-41354] Added manual workflow and updated push-trigger workflow for to support the circular dependency from inji-certify-plugins Signed-off-by: techno-467 <prafulrakhade02@gmail.com> * [MOSIP-41354] Added manual workflow and updated push-trigger workflow for to support the circular dependency from inji-certify-plugins Signed-off-by: techno-467 <prafulrakhade02@gmail.com> * [MOSIP-41354] Added manual workflow and updated push-trigger workflow for to support the circular dependency from inji-certify-plugins Signed-off-by: techno-467 <prafulrakhade02@gmail.com> * [MOSIP-41354] Added manual workflow and updated push-trigger workflow for to support the circular dependency from inji-certify-plugins Signed-off-by: techno-467 <prafulrakhade02@gmail.com> * [MOSIP-41354] Added manual workflow and updated push-trigger workflow for to support the circular dependency from inji-certify-plugins Signed-off-by: techno-467 <prafulrakhade02@gmail.com> * Update pom.xml Signed-off-by: Praful Rakhade <prafulrakhade02@gmail.com> * Updated Dockerfile Signed-off-by: Praful Rakhade <prafulrakhade02@gmail.com> * Updated pom.xml Signed-off-by: Praful Rakhade <prafulrakhade02@gmail.com> * [MOSIP-41354] Added manual workflow and updated push-trigger workflow for to support the circular dependency from inji-certify-plugins Signed-off-by: techno-467 <prafulrakhade02@gmail.com> --------- Signed-off-by: techno-467 <prafulrakhade02@gmail.com> Signed-off-by: Praful Rakhade <prafulrakhade02@gmail.com> * [MOSIP-41354] Added manual workflow and updated push-trigger workflow for to support the circular dependency from inji-certify-plugins (inji#317) * [MOSIP-41354] Added manual workflow and updated push-trigger workflow for to support the circular dependency from inji-certify-plugins Signed-off-by: techno-467 <prafulrakhade02@gmail.com> * [MOSIP-41354] Added manual workflow and updated push-trigger workflow for to support the circular dependency from inji-certify-plugins Signed-off-by: techno-467 <prafulrakhade02@gmail.com> * [MOSIP-41354] Added manual workflow and updated push-trigger workflow for to support the circular dependency from inji-certify-plugins Signed-off-by: techno-467 <prafulrakhade02@gmail.com> * [MOSIP-41354] Added manual workflow and updated push-trigger workflow for to support the circular dependency from inji-certify-plugins Signed-off-by: techno-467 <prafulrakhade02@gmail.com> * [MOSIP-41354] Added manual workflow and updated push-trigger workflow for to support the circular dependency from inji-certify-plugins Signed-off-by: techno-467 <prafulrakhade02@gmail.com> * [MOSIP-41354] Added manual workflow and updated push-trigger workflow for to support the circular dependency from inji-certify-plugins Signed-off-by: techno-467 <prafulrakhade02@gmail.com> * [MOSIP-41354] Added manual workflow and updated push-trigger workflow for to support the circular dependency from inji-certify-plugins Signed-off-by: techno-467 <prafulrakhade02@gmail.com> * [MOSIP-41354] Added manual workflow and updated push-trigger workflow for to support the circular dependency from inji-certify-plugins Signed-off-by: techno-467 <prafulrakhade02@gmail.com> * [MOSIP-41354] Added manual workflow and updated push-trigger workflow for to support the circular dependency from inji-certify-plugins Signed-off-by: techno-467 <prafulrakhade02@gmail.com> * Update pom.xml Signed-off-by: Praful Rakhade <prafulrakhade02@gmail.com> * Updated Dockerfile Signed-off-by: Praful Rakhade <prafulrakhade02@gmail.com> * Updated pom.xml Signed-off-by: Praful Rakhade <prafulrakhade02@gmail.com> * [MOSIP-41354] Added manual workflow and updated push-trigger workflow for to support the circular dependency from inji-certify-plugins Signed-off-by: techno-467 <prafulrakhade02@gmail.com> * [MOSIP-41354] Added manual workflow and updated push-trigger workflow for to support the circular dependency from inji-certify-plugins Signed-off-by: techno-467 <prafulrakhade02@gmail.com> --------- Signed-off-by: techno-467 <prafulrakhade02@gmail.com> Signed-off-by: Praful Rakhade <prafulrakhade02@gmail.com> --------- Signed-off-by: techno-467 <prafulrakhade02@gmail.com> Signed-off-by: Praful Rakhade <prafulrakhade02@gmail.com> Co-authored-by: Praful Rakhade <prafulrakhade02@gmail.com>
Signed-off-by: Praful Rakhade <prafulrakhade02@gmail.com>
[DSD-7977] release changes Signed-off-by: Hitesh Jain <jainhitesh9998@gmail.com>
3ba8937 to
91ddfaf
Compare
47a4625 to
e1f3509
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made
This PR adds proper test coverage for the DID document endpoint and improves code documentation:
/issuance/.well-known/did.jsonendpoint that was missing testsTest Results
All tests are now passing. Screenshot of test results:

Running the tests :
mvn test -pl certify-service -Dtest=VCIssuanceControllerTest