fix(MangaDex): Resolve legacy numeric IDs instead of crashing#122
Draft
kymotsujason wants to merge 1 commit intoinkdex:0.9/stablefrom
Draft
fix(MangaDex): Resolve legacy numeric IDs instead of crashing#122kymotsujason wants to merge 1 commit intoinkdex:0.9/stablefrom
kymotsujason wants to merge 1 commit intoinkdex:0.9/stablefrom
Conversation
- Resolve old numeric manga IDs to UUIDs via legacy API - Return placeholder details when resolution fails (likely doomed though) - Handle legacy IDs across all providers using this new method (Manga, Chapter, Progress, Collection)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the old method of handling legacy (orphaned) manga IDs with the API which apparently still exists.