Fix type error caused by HttpApiListener:is_cron() with null $url
#92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the $response arg passed to HttpApiListener:is_cron() is in fact an array and $url is null or something that results in parse_url() to return null, a TypeError will occur due to basename() only accepting strings
cristianobaptista
changed the title
HttpApiListener:is_cron() with null $urlHttpApiListener:is_cron() with null $url
luislard
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
$responseargument passed toHttpApiListener:is_cron()is in fact an array and$urlis null or something that results inparse_url()returning null, aTypeErrorwill occur due tobasename()only accepting strings.What's Included in This Pull Request
parse_url()is casted to a string.