Prc/rewards fix #126
Open
Prc/rewards fix #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also use real Tau parameter now
Reflects the fact that we process the rewards *after* having pushed the snapshot
Matches Haskell output for pool 30c6319d1f, epoch 213 Added more NOTES
- calculated differently from SPO margin payout!
Now accept parameter change earlier so we have ShelleyParams for epoch 208 - this triggers an additional monetary change, which means we have the correct stake_rewards available when we start epoch 212. Removed 'latest' extra snapshot so we do it all one epoch earlier Made stake_rewards Lovelace outside rewards.rs to keep it simpler Removed fees from snapshot - no longer needed because we have them for previous epoch to hand
Also unused remove SHELLEY_START_SLOT, tidy, pause at 213
Move to AccountState so we can filter against previous versions and log only what we're interested in
…s into prc/rewards-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add another layer of snapshot queue, fix margin calculations - now matches rewards paid in 213 except for SPO's own reward account, which we don't yet filter out.
Also use real parameter value for 'tau' now we can rely on it.