feat(cat-voices): Add multi-package support to flutter_rust_bridge #448
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dt-iohk
added
do not merge yet
dt-iohk
added
squad: face
8 tasks
dt-iohk
added
review me
bkioshn
reviewed
Sep 12, 2025
bkioshn
reviewed
Sep 12, 2025
| # https://blog.rust-lang.org/2025/04/04/c-abi-changes-for-wasm32-unknown-unknown/ | ||
| RUN flutter_rust_bridge_codegen build-web | ||
| # TODO(dt-iohk): revert to official version when changes are merged | ||
| GIT CLONE --branch feat/wasm_bindgen_configurable https://github.com/dt-iohk/flutter_rust_bridge.git /usr/local/flutter_rust_bridge |
There was a problem hiding this comment.
I'm okay of doing it this way, but let's comment out flutter_rust_bridge thing from INSTALL_TOOLS and tool-flutter-rust-bridge-codegen and make some note there.
There was a problem hiding this comment.
Done. These changes are temporary. I hope it's short lived rather than long-lived but depends on how much time it'll take to merge it to the original lib.
There was a problem hiding this comment.
For clarification, I'm not going to merge this PR while it still points to my own fork, I'll wait until we have the IOHK one.
dt-iohk
added
do not merge yet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See input-output-hk/catalyst-voices#3370 for description.
Related Issue(s)
Refers input-output-hk/catalyst-voices#3266
Please confirm the following checks