Minor Improvements#13
Open
JimmyAstle wants to merge 16 commits intoinsentia:masterfrom
Simspace:master
Open
Conversation
added 5 commits
June 4, 2015 13:03
Jimmy Astle The alternative of failing on a 2008r2 machine means one would need different class/yamls for 2008r2 and 2012r2
Jimmy Astle Lets the puppet apply finish clean.
Jimmy Astle Cleaner way to handle reboot after install is finished.
…re of powershell command used to create users.
s0lucien
pushed a commit
to s0lucien/windows_ad
that referenced
this pull request
Sep 1, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding in support to not fail if installmanagementtools is specified on a 2008r2 install
Adding in the successful install return codes that DCPromo returns after install
Allow puppet to reboot instead of the domain install action.
Tested all changes on both OS's